refactor: docker-build-push-action #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehabhalodiya
force-pushed
the
gh-action
branch
from
fdd9b89 to
0c06eba
Compare
christian-kreuzberger-dtx
requested changes
Apr 26, 2022
There was a problem hiding this comment.
Hi, sorry to disappoint you, but that's not what the description in #118 meant.
- We still want to keep using
keptn/gh-automation/.github/actions/docker-build, I just referred to thedocker/build-push-actionas the example implementation - You are missing the step
repo_slug
Signed-off-by: mehabhalodiya <[email protected]>
Signed-off-by: mehabhalodiya <[email protected]>
mehabhalodiya
force-pushed
the
gh-action
branch
from
b0554e9 to
337381b
Compare
mehabhalodiya
changed the title
|
Hi @mehabhalodiya , thanks for trying! In the meantime, I've had @TannerGabriel take a look at this and he created and merged a PR: #131 If you want to see the final solution, please take a look at his PR ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #118