This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
feat!: Use data explorer metric expressions #883
Merged
arthurpitman
merged 26 commits into
master
from
feat/use-data-explorer-metric-expressions
Sep 8, 2022
Merged
feat!: Use data explorer metric expressions #883
arthurpitman
merged 26 commits into
master
from
feat/use-data-explorer-metric-expressions
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faffb5c
to
919bebe
Compare
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
752d06a
to
a5559c7
Compare
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
a5559c7
to
54c0fe4
Compare
j-poecher
suggested changes
Aug 29, 2022
...tdata/dashboards/data_explorer/metric_expressions/metrics_builtin_service_response_time.json
Outdated
Show resolved
Hide resolved
...ta_explorer/metric_expressions/metrics_query_builtin_service_response_time_avg_multiple.json
Outdated
Show resolved
Hide resolved
...data_explorer/metric_expressions/metrics_query_builtin_service_response_time_avg_single.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
j-poecher
previously approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Improve structure of created event adapter log message Signed-off-by: Arthur Pitman <[email protected]> * Retrigger workflow Signed-off-by: Arthur Pitman <[email protected]> Signed-off-by: Arthur Pitman <[email protected]>
j-poecher
previously approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Arthur Pitman <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
The following Docker Images have been built: |
j-poecher
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
arthurpitman
added a commit
that referenced
this pull request
Oct 14, 2022
* Enhance `metrics.Query` Signed-off-by: Arthur Pitman <[email protected]> * Simplify error processing in metrics queries Signed-off-by: Arthur Pitman <[email protected]> * Build indicator names purely based on results Signed-off-by: Arthur Pitman <[email protected]> * Remove `queryComponents` Signed-off-by: Arthur Pitman <[email protected]> * Omit `SpaceAggregation` in Data Explorer queries when empty Signed-off-by: Arthur Pitman <[email protected]> * `Allow multiple templates in `TemplatingPayloadBasedURLHandler` Signed-off-by: Arthur Pitman <[email protected]> * Use template for Data Explorer management zone tests and expand coverage Signed-off-by: Arthur Pitman <[email protected]> * Use template for Data Explorer space aggregation tests Signed-off-by: Arthur Pitman <[email protected]> * Investigate and fix test Signed-off-by: Arthur Pitman <[email protected]> * Improve Data Explorer SplitBy and FilterBy tests Signed-off-by: Arthur Pitman <[email protected]> * Remove redundant SplitBy and FilterBy Data Explorer tests Signed-off-by: Arthur Pitman <[email protected]> * Remove redundant test Signed-off-by: Arthur Pitman <[email protected]> * Use template for Data Explorer management zone tests and expand coverage Signed-off-by: Arthur Pitman <[email protected]> * Append indicator suffix also to display name Signed-off-by: Arthur Pitman <[email protected]> * Remove unneeded tests in preparation Signed-off-by: Arthur Pitman <[email protected]> * Use provided metric expression Signed-off-by: Arthur Pitman <[email protected]> * Minimal documentation update Signed-off-by: Arthur Pitman <[email protected]> * Go mod tidy Signed-off-by: Arthur Pitman <[email protected]> * Automated addition of newline to end of text files Signed-off-by: Arthur Pitman <[email protected]> * Improve logging of SLI results Signed-off-by: Arthur Pitman <[email protected]> * Improve processing and error messages for Metrics v2 queries Signed-off-by: Arthur Pitman <[email protected]> * Improve logging with JSONFormatter Signed-off-by: Arthur Pitman <[email protected]> * Log basic fields of events Signed-off-by: Arthur Pitman <[email protected]> * feat: Improve structure of created event adapter log message (#900) * Improve structure of created event adapter log message Signed-off-by: Arthur Pitman <[email protected]> * Retrigger workflow Signed-off-by: Arthur Pitman <[email protected]> Signed-off-by: Arthur Pitman <[email protected]> * Revert to `logrus.TextFormatter` Signed-off-by: Arthur Pitman <[email protected]> Signed-off-by: Arthur Pitman <[email protected]>
This was referenced Oct 25, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.