Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

feat!: Use data explorer metric expressions #883

Merged
merged 26 commits into from
Sep 8, 2022

Conversation

arthurpitman
Copy link
Collaborator

No description provided.

@arthurpitman arthurpitman force-pushed the feat/use-data-explorer-metric-expressions branch from faffb5c to 919bebe Compare August 23, 2022 07:42
@arthurpitman arthurpitman changed the title Feat: use data explorer metric expressions feat: Use data explorer metric expressions Aug 23, 2022
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman arthurpitman force-pushed the feat/use-data-explorer-metric-expressions branch from 752d06a to a5559c7 Compare August 26, 2022 10:37
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman arthurpitman force-pushed the feat/use-data-explorer-metric-expressions branch from a5559c7 to 54c0fe4 Compare August 28, 2022 11:50
@arthurpitman arthurpitman marked this pull request as ready for review August 28, 2022 11:57
@arthurpitman arthurpitman changed the title feat: Use data explorer metric expressions feat!: Use data explorer metric expressions Aug 28, 2022
j-poecher
j-poecher previously approved these changes Sep 6, 2022
Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* Improve structure of created event adapter log message

Signed-off-by: Arthur Pitman <[email protected]>

* Retrigger workflow

Signed-off-by: Arthur Pitman <[email protected]>

Signed-off-by: Arthur Pitman <[email protected]>
j-poecher
j-poecher previously approved these changes Sep 6, 2022
Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Arthur Pitman <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

The following Docker Images have been built:
keptncontrib/dynatrace-service:0.23.3-dev-PR-883,keptncontrib/dynatrace-service:0.23.3-dev-PR-883.202209080815

Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurpitman arthurpitman merged commit 9012758 into master Sep 8, 2022
@arthurpitman arthurpitman deleted the feat/use-data-explorer-metric-expressions branch September 8, 2022 08:26
arthurpitman added a commit that referenced this pull request Oct 14, 2022
* Enhance `metrics.Query`

Signed-off-by: Arthur Pitman <[email protected]>

* Simplify error processing in metrics queries

Signed-off-by: Arthur Pitman <[email protected]>

* Build indicator names purely based on results

Signed-off-by: Arthur Pitman <[email protected]>

* Remove `queryComponents`

Signed-off-by: Arthur Pitman <[email protected]>

* Omit `SpaceAggregation` in Data Explorer queries when empty

Signed-off-by: Arthur Pitman <[email protected]>

* `Allow multiple templates in `TemplatingPayloadBasedURLHandler`

Signed-off-by: Arthur Pitman <[email protected]>

* Use template for Data Explorer management zone tests and expand coverage

Signed-off-by: Arthur Pitman <[email protected]>

* Use template for Data Explorer space aggregation tests

Signed-off-by: Arthur Pitman <[email protected]>

* Investigate and fix test

Signed-off-by: Arthur Pitman <[email protected]>

* Improve Data Explorer SplitBy and FilterBy tests

Signed-off-by: Arthur Pitman <[email protected]>

* Remove redundant SplitBy and FilterBy Data Explorer tests

Signed-off-by: Arthur Pitman <[email protected]>

* Remove redundant test

Signed-off-by: Arthur Pitman <[email protected]>

* Use template for Data Explorer management zone tests and expand coverage

Signed-off-by: Arthur Pitman <[email protected]>

* Append indicator suffix also to display name

Signed-off-by: Arthur Pitman <[email protected]>

* Remove unneeded tests in preparation

Signed-off-by: Arthur Pitman <[email protected]>

* Use provided metric expression

Signed-off-by: Arthur Pitman <[email protected]>

* Minimal documentation update

Signed-off-by: Arthur Pitman <[email protected]>

* Go mod tidy

Signed-off-by: Arthur Pitman <[email protected]>

* Automated addition of newline to end of text files

Signed-off-by: Arthur Pitman <[email protected]>

* Improve logging of SLI results

Signed-off-by: Arthur Pitman <[email protected]>

* Improve processing and error messages for Metrics v2 queries

Signed-off-by: Arthur Pitman <[email protected]>

* Improve logging with JSONFormatter

Signed-off-by: Arthur Pitman <[email protected]>

* Log basic fields of events

Signed-off-by: Arthur Pitman <[email protected]>

* feat: Improve structure of created event adapter log message (#900)

* Improve structure of created event adapter log message

Signed-off-by: Arthur Pitman <[email protected]>

* Retrigger workflow

Signed-off-by: Arthur Pitman <[email protected]>

Signed-off-by: Arthur Pitman <[email protected]>

* Revert to `logrus.TextFormatter`

Signed-off-by: Arthur Pitman <[email protected]>

Signed-off-by: Arthur Pitman <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants