Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drawing on map to create paths and polygons #389

Closed
heshan0131 opened this issue Feb 28, 2019 · 20 comments
Closed

Allow drawing on map to create paths and polygons #389

heshan0131 opened this issue Feb 28, 2019 · 20 comments
Assignees
Labels

Comments

@heshan0131
Copy link
Contributor

Free Draw

  • Use nebula.gl to allow a user to freely draw on the map and create polygons and paths. New geometries will be added to a geometry filter.

  • Add UI to guide drawing process (Need UI/UX design). Confirm closing polygon, and edit polygon waypoints.

  • In the drawing UI, allow a user to select layers to be filtered by the new geometry

@tusheet
Copy link

tusheet commented May 21, 2019

Hi Shan He,
Wondering on the updates on this and if there have been any changes to the expected timelines for Milestone 2: Geo Operations.

Regards,
Tusheet

@MosheMalin
Copy link

Hi,
Is there maybe an update about this item? It's a really must..
If it's not close, how would you recommend to add something that draws polygons in the meanwhile?

@heshan0131
Copy link
Contributor Author

heshan0131 commented Jun 17, 2019 via email

@MosheMalin
Copy link

Thanks.
The use case is quite simple (at least to describe..): Draw a polygon, get its coordinates. Also be able to delete it.
Obviously more options (like: move/edit/color/etc) would be nice, but the above is the minimal use case.

Moshe

@macrigiuseppe macrigiuseppe self-assigned this Jun 17, 2019
@macrigiuseppe
Copy link
Collaborator

@heshan0131
Copy link
Contributor Author

@macrigiuseppe
Copy link
Collaborator

@macrigiuseppe please talk to @xintongxia about using react-map-gl-draw

https://github.com/uber/nebula.gl/blob/xx/react-map-gl-draw-rfc/dev-docs/RFCs/v1.0/react-map-gl-draw.md

@heshan0131 I already started implementing react-map-gl-draw in kepler. I will reach out to @thelinuxfoundation for questions.

@bragilev
Copy link

Hi
Maybe you can suggest some workaround how to use the react-map-gl-draw in kepler ? And what is your estimation for the official release that will contain this feature ?
Thanks

@macrigiuseppe
Copy link
Collaborator

Hi
Maybe you can suggest some workaround how to use the react-map-gl-draw in kepler ? And what is your estimation for the official release that will contain this feature ?
Thanks

We are currently working on this. We don't have a precise estimate for this feature to go out

@briantcl
Copy link
Contributor

update: June 28

  • done with the integration
  • pending improvements in the UX in selecting and editing polygon based on limitations in react-map-gl draw

@bragilev
Copy link

bragilev commented Jul 1, 2019 via email

@macrigiuseppe
Copy link
Collaborator

Hi We found a workaround for using polygon in kepler.gl by integration map.gl component and kepler.gl component with the same mapbox reference. In KeplerGL "getMapboxRef={(mapbox, index) => this._getMapboxRef(mapbox, index)}" gave us the reference to mapbox. In MapGL "<MapGL {...this.state.mapbox.props}" gave us the desired connection between the two components. And using z-index we succeeded to show the Editor and Toolbar on front of KeplerGL map and MapGl map was moved to invisible background.

On Fri, Jun 28, 2019 at 9:08 PM Brian Tsang @.***> wrote: update: June 28 - done with the integration - pending improvements in the UX in selecting and editing polygon based on limitations in react-map-gl draw — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#389?email_source=notifications&email_token=ADILFQHP6G4QYJTKW27NQ2LP4ZHQJA5CNFSM4G2XJBM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2ZITY#issuecomment-506827855>, or mute the thread https://github.com/notifications/unsubscribe-auth/ADILFQC47UR523IMZUL5IDTP4ZHQJANCNFSM4G2XJBMQ .

This feature is still a work in progress. We will provide updates.

@heshan0131
Copy link
Contributor Author

uber/nebula.gl#254.

@amaton
Copy link

amaton commented Feb 15, 2020

Hi Shan He;
Is there updates on this topic?

@macrigiuseppe
Copy link
Collaborator

Hi Shan He;
Is there updates on this topic?

@amaton this feature was implemented in #595 and it's already available on our demo site: https://kepler.gl/

@donniekerr
Copy link

Can you use the kepler.gl api to programmatically draw a polygon? I don't see drawing-related actions/reducers in the docs?

@ramilrgk
Copy link

ramilrgk commented Apr 25, 2023

Hi! Please add the functionality to create circular polygons like in nebula.gl. This would be very useful for geophysical applications, and I think many more! It is also not very clear whether the created polygon is being recorded somewhere? I know that it is possible to copy the polygon data to the clipboard. But I would like to have some kind of automatic solution that saves marks

I mean circles created from the center with a stretchable radius, or ellipses from three points. In general, many other functions would also be useful, such as measuring angles or area, these tools are wonderful!

@hikaru-xg
Copy link

hikaru-xg commented Aug 16, 2023

Hi, @macrigiuseppe
Is there any future update for drawing paths (Linestring) function?
Since the title of this ticket includes "paths", I hope drawing linestrings function implemented.

Also, I was trying to work around by modifying "kepler.gl/dist/contstants/default-setting.js" and MapDrawPanelFactory to accept "DRAW_PATH mode" of react-map-gl-draw.
It works somehow, but coudn't close the feature. ( I mean, couldn't finish the linestring)
Is there any suggestion?

@indranildeveloper
Copy link
Contributor

How I can use Nebula GL with Kepler GL?

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 17, 2024

@indranildeveloper If you have a question please open a discussion in the Discussions taB. No one is going to pay attention to old closed issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests