Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): relax Node version requirement to >= 6 #14

Merged
merged 1 commit into from
Mar 22, 2018
Merged

feat(node): relax Node version requirement to >= 6 #14

merged 1 commit into from
Mar 22, 2018

Conversation

wKovacs64
Copy link
Contributor

What: dropping Node version requirement to >=6

Why: allows react-testing-library to be used in older runtime environments

How: modified engines stanza in package.json

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Closes #12.

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          10     10           
  Branches        1      1           
=====================================
  Hits           10     10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98987c8...0a797ba. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks!

@kentcdodds kentcdodds merged commit 01a42fe into testing-library:master Mar 22, 2018
@wKovacs64 wKovacs64 deleted the pr/engines branch March 22, 2018 17:37
julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
* Update fireEvent example to use correct method

* Updates contributor list

* Update fireEvent docs to include container
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

engines config breaks deploys to Netlify
2 participants