Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #15

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Update documentation #15

merged 2 commits into from
Feb 13, 2020

Conversation

bj-mcduck
Copy link

@bj-mcduck bj-mcduck commented Feb 12, 2020 •
edited
Loading

I found the documentation confusing on first read, so I've updated it with the information I found in your issues backlog.

@bj-mcduck bj-mcduck requested a review from kentaro-m February 12, 2020 18:23
@bj-mcduck
Copy link
Author

I personally went with .github/auto_assign_config.yml, and I think it makes for a better default.
The auto_assign name makes sense for a name to use as a workflow, but it's weird if your config file is named the same thing.

Just my two cents.

kentaro-m
kentaro-m approved these changes Feb 13, 2020
View reviewed changes
Copy link
Owner

@kentaro-m kentaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @brandonjmckay. Thanks for improving the document 👍

@kentaro-m kentaro-m merged commit 0530a15 into kentaro-m:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentaro-m kentaro-m kentaro-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj-mcduck @kentaro-m