Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Node 12 #115

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Remove support for Node 12 #115

merged 2 commits into from
Jun 22, 2021

Conversation

billyjanitsch
Copy link
Collaborator

Closes #114.

Just a formality. This is generally considered a breaking change, so it should be merged right before the next major release. (But not sooner, in case we want to cut any minor/patch releases in the meantime.)

@billyjanitsch billyjanitsch requested a review from a team as a code owner June 4, 2021 05:04
Copy link
Contributor

@nabeel- nabeel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving a stamp now for whenever we end up needing to merge this

@billyjanitsch billyjanitsch merged commit 54962c3 into main Jun 22, 2021
@billyjanitsch billyjanitsch deleted the billy/rm-node-12 branch June 22, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Node 12
2 participants