Support naming toolchains and --force #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2018
|
I'm fine with MASTER=$(rustup-toolchain-install-master --github-token "$TOKEN") &&
cargo +"$MASTER" buildAnd with rustup uninstall master(this command always return 0 even with non-existing toolchain) |
|
|
kennytm
approved these changes
Jul 21, 2018
src/main.rs
Outdated
| @@ -238,6 +252,10 @@ fn run() -> Result<(), Error> { | |||
| exit(1); | |||
| } | |||
|
|
|||
| if args.commits.len() > 1 && args.name.is_some() { | |||
| eprintln!("name argument can only be provided with a single commit"); | |||
| } | |||
There was a problem hiding this comment.
This should be followed by an early exit.
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "rustup-toolchain-install-master" | |||
| version = "1.1.0" | |||
| version = "1.1.1" | |||
src/main.rs
Outdated
| } else { | ||
| Cow::Borrowed(toolchain.commit) | ||
| Cow::Borrowed(toolchain.name) |
There was a problem hiding this comment.
If we run --alt --name somename we'll end up with a somename-alt toolchain, which might be surprising.
Perhaps move this logic to where the struct is constructed?
|
Fixed |
|
Published 1.2.0 to crates.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to call
cargo +master buildor whatever. We may even want the default to bemasterwhen invoked with no commit hash.Currently it's annoying to use this in CI since I have to recalculate the hash so that I can use the toolchain.
r? @kennytm`