wip - rollback returning values in actions (not allowed w/ immer)

kennyfrc · Jul 17, 2024 · 9767c80 · 9767c80
1 parent ac8c231
commit 9767c80
Show file tree

Hide file tree

Showing 6 changed files with 12,756 additions and 63 deletions.
diff --git a/build/cami.cdn.js b/build/cami.cdn.js
diff --git a/build/cami.cdn.js.map b/build/cami.cdn.js.map
diff --git a/build/cami.module.js b/build/cami.module.js
diff --git a/build/cami.module.js.map b/build/cami.module.js.map
diff --git a/docs/javascripts/cami.cdn.js b/docs/javascripts/cami.cdn.js
diff --git a/src/observables/observable-store.js b/src/observables/observable-store.js
@@ -265,14 +265,13 @@ class ObservableStore extends Observable {
 
       if (!reducer) {
         console.warn(`No reducer found for action ${action}`);
-        return;
+        return _deepClone(this._state);
       }
 
       this.__applyMiddleware(action, payload);
 
-      let actionResult;
       const [nextState, patches, inversePatches] = produceWithPatches(this._state, draft => {
-        actionResult = reducer({
+        reducer({
           state: draft,
           payload: payload,
           dispatch: this.dispatch.bind(this),
@@ -282,7 +281,6 @@ class ObservableStore extends Observable {
           memo: this.memo.bind(this),
           trigger: this.trigger.bind(this)
         });
-        return actionResult === undefined ? draft : actionResult;
       });
 
       try {
@@ -320,7 +318,7 @@ class ObservableStore extends Observable {
         }
       }
 
-      return actionResult !== undefined ? actionResult : _deepClone(this._state);
+      return _deepClone(this._state);
     } finally {
       this.__dispatchStack.pop();
       this.__isDispatching = false;