Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content rendering #631

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fix content rendering #631

merged 1 commit into from
Feb 24, 2022

Conversation

matthewmcgarvey
Copy link
Contributor

Fixes #630

Turns out that you have to call ECR.embed and pass in an IO::Memory or it breaks the content_for macro.

Tried to update the specs to catch the problems in the future. For the record, the added spec never failed, it was added as a precaution.

@matthewmcgarvey matthewmcgarvey mentioned this pull request Feb 24, 2022
Closed
sdogruyol
sdogruyol approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @matthewmcgarvey 🙏

@sdogruyol sdogruyol merged commit d6dc893 into kemalcr:master Feb 24, 2022
@matthewmcgarvey matthewmcgarvey deleted the render-content branch February 24, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering HTML with layout file double renders the inner content
3 participants
@matthewmcgarvey @straight-shoota @sdogruyol