Fix StaticFileHandler failing spec #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Feb 25, 2021
The update concerns the other two tests concerning gzip. As of now, the response was being automatically ungzipped if ContentEncoding was set to gzip, rendering the two tests basically useless. Adding decompress: false to both of them actually does not remove the ContentEncoding header, so that we can ensure that the response is not actually gzipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Change fixes the build failing due to http module now removing ContentEncoding is decompress param is set to true, see also Issue #594
Benefits
Build should work again now.
Possible Drawbacks
No checks are actually performed on the body of the response. But really, this I think was not the spec of the spec