Cleanup ameba warnings #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
cleanup-ameba-warnings
branch
from
a933db4 to
cd3124c
Compare
jkthorne
reviewed
Aug 26, 2019
| @@ -1,6 +1,7 @@ | |||
| class HTTP::Server::Response | |||
| class Output | |||
| def close | |||
| # ameba:disable Style/NegatedConditionsInUnless | |||
| unless response.wrote_headers? && !response.headers.has_key?("Content-Range") | |||
There was a problem hiding this comment.
can this be turned into an if statement?
if !response.wrote_headers? && response.headers.has_key?("Content-Range")
There was a problem hiding this comment.
Please let's not do that again 😸
There was a problem hiding this comment.
The correct way of using if here is:
if !response.wrote_headers? || response.headers.has_key?("Content-Range")
jkthorne
reviewed
Aug 26, 2019
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| module Kemal | |||
| class StaticFileHandler < HTTP::StaticFileHandler | |||
| # ameba:disable Metrics/CyclomaticComplexity | |||
There was a problem hiding this comment.
Would this be worth tuning instead of ignoring?
There was a problem hiding this comment.
I'd leave it for another PR.
Sija
force-pushed
the
cleanup-ameba-warnings
branch
from
cd3124c to
e8330ed
Compare
sdogruyol
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #520, #538