Remove gcr.io/k8s-skaffold repository from examples (GoogleContainerT…

…ools#3368) * Always use the default repository `gcr.io/k8s-skaffold` in tests Signed-off-by: Cornelius Weig <[email protected]> * Remove gcr.io/k8s-skaffold repository from image names Signed-off-by: Cornelius Weig <[email protected]> * Convert former default-repo test to explicit repo tests Signed-off-by: Cornelius Weig <[email protected]> * Adapt image names in examples Signed-off-by: Cornelius Weig <[email protected]> * Revert helm integration test Skaffold deploy with default-repo seems to be not working that way. * Restrict flags to core commands in test-helper Flags such as --namespace or --default-repo are applied to "all" Skaffold commands, but this only applies to all core commands. Make the test helper a bit smarter to not forward unknown arguments. Signed-off-by: Cornelius Weig <[email protected]> * Adapt expectations to account for --default-repo=gcr.io/k8s-skaffold in integration tests Signed-off-by: Cornelius Weig <[email protected]> * Silently ignore unknown flags in integration tests When passing unknown flags to skaffold in integration tests, the tests rightfully fails. However, for simpler test setup it is desirable to unconditionally set some configurations. This change ensures that those flags will not break the integration tests. Signed-off-by: Cornelius Weig <[email protected]> * Use default repo in buildpack example Signed-off-by: Cornelius Weig <[email protected]> * Revert helm-test: use fully qualified image name * Change to fully qualified image in explicit repo integration test
kelsk · Jan 16, 2020 · f5baccb · f5baccb
1 parent a0fae9c
commit f5baccb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/k8s/node.yaml b/k8s/node.yaml
@@ -24,6 +24,6 @@ spec:
     spec:
       containers:
       - name: node
-        image: gcr.io/k8s-skaffold/node-example
+        image: node-example
         ports:
         - containerPort: 3000
diff --git a/k8s/python.yaml b/k8s/python.yaml
@@ -24,6 +24,6 @@ spec:
     spec:
       containers:
       - name: python
-        image: gcr.io/k8s-skaffold/python-reload
+        image: python-reload
         ports:
         - containerPort: 5000
diff --git a/skaffold.yaml b/skaffold.yaml
@@ -2,12 +2,12 @@ apiVersion: skaffold/v2alpha1
 kind: Config
 build:
   artifacts:
-  - image: gcr.io/k8s-skaffold/node-example
+  - image: node-example
     context: node
     sync:
       infer:
       - 'src/**/*.js'
-  - image: gcr.io/k8s-skaffold/python-reload
+  - image: python-reload
     context: python
     sync:
       infer: