Fix ls-files call in large monorepos #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyselden
requested changes
Aug 28, 2019
|
Okay I brought back the separate function. Let me know if you have other notes. |
kellyselden
approved these changes
Aug 29, 2019
|
Thank you! It should be released soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this issue when trying to run
ember-cli-updatein a large monorepo. It kept giving errors which led me to #269 and the accompanying issue ember-cli/ember-cli-update#583.The fix in the above PR did not create a big enough buffer for the monorepo I was trying to use this on. Rather than trying to bump up the buffer size again which seems to not be a general solution I created a secondary command execution strategy which uses
spawnrather thanexecbecausespawnis a stream rather than a buffer. This seems to fix the problem although the runtime is quite long still for such a big repo.Happy to make any tweaks necessary or rethink things if it helps.