Development Build(2024-04-19)

Bug Fixes

• Implement EndSpline which removes moveflags and calls _Finalize #647 (David)

Chores

• Included githubactions in the dependabot config (neilnaveen)

Commits

• b97e9d0: Add missing spell 20409 for Onyxia transform. (evil-at-wow)
• Remove redundant code (killerwife)
• Add castItem to OnAuraValueCalculate (killerwife)
• 5d15c9a: Spell/Auras: Implement last custom aura damage switchcase using spell scripts (killerwife)
• 7425cdf: Spell/Warlock: Port healthstone script to spell scripts (killerwife)
• Partial rewrite of hydross (killerwife)
• Add missing comment naming to all existing class spell scripts (killerwife)
• Fix typo preventing healthstone create and typo assigning pala script (killerwife)
• Fix kazzak twisted reflection healing tank (killerwife)
• Rework Hydross using spell lists, BCT, CombatAI and area aura for transition (killerwife)
• Fix SCRIPT_FLAG_BUDDY_BY_GUID with dynguid (killerwife)
• Port thrall script to bct (killerwife)
• fbf9a82: Fix unit_condition not being insertable on db end (killerwife)
• Implement s.27673 (killerwife)
• f74ec94: Add s.44288 (killerwife)
• 7f53efb: Unit/Creature: Implement CreatureStaticFlags::DESPAWN_INSTANTLY (killerwife)
• 20d02f8: Shattered Hand Centurion: fix unreachable aggro text. (evil-at-wow)
• b9b75f3: Another round of GCC/Clang 'unused parameter' compiler warning fixes. (evil-at-wow)
• abf267b: Fix excessive arguments for a format string. (evil-at-wow)
• remove superfluous checks. (evil-at-wow)
• add missing initializer creating a GhostOPlasmEvent. (evil-at-wow)
• 8d7a5af: Fix a memory leak in scripts. (evil-at-wow)
• Implement SPELL_LIST_FLAG_NON_BLOCKING (killerwife)
• Remove FiveFatFingerExplodingHeartTechnique on effect execute (killerwife)
• simplify/modernize. Callback: remove, no longer needed. (evil-at-wow)
• 6a4764c: Improve Database API to avoid memory leaks in the future, part 1. (evil-at-wow)
• f71ec05: Improve Database API to avoid memory leaks in the future, part 2. (evil-at-wow)
• 7c8f161: Improve Database API to avoid memory leaks in the future, part 3. (evil-at-wow)
• fadd15e: Improve WorldPacket API. (evil-at-wow)
• 688db50: Fix sending empty packet for locked servers caused by wrong variable. (evil-at-wow)
• fd9e5b7: Narrow the scope of (WorldPacket) variables to avoid a shadow variable. (evil-at-wow)
• 9800d9b: Fix GetCreatureCooldown() to use a reference for the out parameter. (evil-at-wow)
• 45a504c: Add bodley replacement spells (killerwife)
• Fix crash due to enemy not existing on assist aggro (killerwife)
• 6b88436: Spell 27978 should not apply UNIT_AURAFLAG_ALIVE_INVISIBLE (killerwife)
• Add missing backport for script s.26264 (killerwife)
• 1c82f5b: [SD] Add missing Aura Passives to npcs (AnonXS) #635
• Implement CONFIG_BOOL_DISABLE_INSTANCE_RELOCATE (killerwife)
• Rework Kael using spell scripts, combat ai, bct and spell lists (killerwife)
• Make flamestrike npc despawn and not chase around (killerwife)
• Modernize Dashel Stonefist to support spell lists (killerwife)
• Add detail to dashel stonefist (killerwife)
• Make shapeshift forms which dont override attack speed use weapon damage (killerwife)
• Disable sending packet with aura removal for self when possessed (killerwife)
• 866477b: Update GitHub Workflows (Niam5)
• 018f544: Update Github workfows spellings (Jimmy B)
• a9129b4: Update Github Workflows to boost 1.83 (Cyberium)
• 9828959: Should fix win build (Cyberium)
• b36a148: Add missing vanilla spells (killerwife)
• Implement .npc despawn command (killerwife)
• Refactor non spawn group dynguid code to account for despawn on grid load (killerwife)
• Fix string id objects not being cleared on despawn (killerwife)
• 75e9ce7: Move spell to correct section (killerwife)
• 1789a95: Spell/Unit: Add absorb information to proc system (killerwife)
• Eye for an eye should also use absorbed damage in reflection (killerwife)
• 80ef1dd: Spell/Unit: Make PROC_EX_ABSORB tagged hits also proc on full absorb (killerwife)
• Fix passing of wrong proc flag to PROC_EX_CAST_END event and minor logic simplification (killerwife)
• Fix spells with negative SPELL_EFFECT_THREAT and SPELL_ATTR_EX_NO_THREAT (killerwife)
• Also use Damage Done Multiplier script setting in healing (killerwife)
• 2596525: Fix combat_condition not being insertable on db end (killerwife)
• Add error if creature_template_spells is conflicting with creature_spell_list_entry (killerwife)
• Fix UpdateEntry protocol not working whilst being ridden by player (killerwife)
• Script for Q.8519 Removed (Grz3s)
• 886393f: Fix crash in BattleGroundWS.cpp due to wrong argument passed to IsFlagPickedUp() (Karth)
• Clear item pointer on consumption (killerwife)
• Refactor corpse reclaim delay code to fix crash (Karth)
• Implement m_effectSkipMask (killerwife)
• Enforce los ignore due to range index 13 for single target targeting (killerwife)
• d2d9ec7: Revert text back to vanilla version (killerwife)
• Adjust masked SPELL_AURA_MOD_HIT_CHANCE applying to wrong weapon types (killerwife)
• Defer insertion of spawns during SpawnManager::Update (killerwife)
• Fix previous commit through move insertion (killerwife)
• Fix spawning and respawning of dynguids using command and on map init (killerwife)
• Safeguard respawning of creature grouped dynguids in respawn command (killerwife)
• 6c9da3d: Add some missing vanilla serversides (killerwife)
• Tryfix exploit for when dead player is being revived in different instance id (killerwife)
• 97e451e: Fix .npc spawntime gm command (David) #641
• f0f895f: Fix string format in spawntime chat command handler (David) #642
• 431331c: Fix ObjectMgr::IsRandomDbGuidDynguided(). (evil-at-wow)
• fix missing member initializer. (evil-at-wow)
• 0254a05: Kalimdor scripts: add missing breaks. (evil-at-wow)
• Add missing SCRIPT_FLAG_BUDDY_BY_STRING_ID to doc file (killerwife)
• Fix interaction of SCRIPT_FLAG_BUDDY_BY_STRING_ID and SCRIPT_COMMAND_TERMINATE_SCRIPT (killerwife)
• Implement SCRIPT_FLAG_BUDDY_IS_DESPAWNED for SCRIPT_FLAG_BUDDY_BY_STRING_ID (killerwife)
• a498dab: Resolve compiler warnings (Scarabol) #647
• 40962a6: Fix set facing for objects leaving dirty movement flags behind (Scarabol) #647
• Properly encapsulate weapon hit chance recalculation on item operations (killerwife)
• Fix door to boss magtheridon (XandrNiko)
• Fix door to boss arlokk (XandrNiko)
• f5b08d9: Instance/GO: Implement OnObjectDespawn (killerwife)
• 33760d2: World/HFP: Reimplement Magtheridons head to be despawned and respawn on quest (killerwife)
• Add threat reset to normal charge (killerwife)
• 4232dfc: [s2472] Creature/Gameobject: Upgrade precision of GO and creature positions (killerwife)
• 1a81596: Creature/GameObject: Do not spawn dynguid spawns by default if they are part of game_event (killerwife)
• Make divine intervention bounce if target is carrying a BG flag (killerwife)
• 3615f1c: SpawnGroup/Creature/GameObject: Spawn group dbguids should not be affected by dynguid flag ccode (killerwife)
• Implement go next command for sequence teleporting (killerwife)
• 50dcf7a: GameEvent/Dynguid: Rework spawning of game event spawns (killerwife)
• Fix missing init of m_updated (killerwife)
• e9aa973: Add reference support for grouped loot tables. (Cyberium)
• ca97309: Add cyclic detection for loot reference (Cyberium)
• 1ebd794: Unwanted value copies fixes. (Cyberium)
• Add SQLite DB backend support #650 (insunaa)
• Fix null-data handling #651 (insunaa)
• 5b7cb1a: Core/PacketIO: Implemented CMSG_BUSY_TRADE and CMSG_IGNORE_TRADE (killerwife)
• Add dyngo fake caster support (killerwife)
• 17eff1e: Fix mistake when updating score in Alterac Valley (Karth)
• b9ed3be: Don't generate pet number twice on tame. (celguar)
• 06e56c4: Prevent unneeded item_instance update when loading from db. (mostlikely4r)
• 4f146c6: Remove suspicious comma (gromchek)
• 1155b2b: [SD] Magtheridon: SetInCombatWithZone when he is freed, Cleave Timer (AnonXS)
• b4668ed: [Spell] Fire Shield 13377 should not be removed on Evade (AnonXS) #628
• c8743cd: [Spell] 16577 Disease Cloud should not be removed on Evade (AnonXS) #628
• 8d500cf: [Spell] Spirit Particles 17327 should not be removed on Evade (AnonXS) #628
• 0f63863: [Spell] Double Attack 19817 should not be removed on Evade (AnonXS) #628
• ad9eca3: [Spell] Shield Spike 12782 & Wither Touch 13483 should not be removed on Evade (AnonXS) #628
• afeebec: [Spell] Deadly Poison 21788 should not be removed on Evade (AnonXS) #628
• b12eb52: [Spell] Spirit Particles (green) 18951 should not be removed on Evade (AnonXS) #628
• 9e20553: [Spell] Grip of Command 21130 should not be removed on Evade (AnonXS) #628
• 1f257e8: [Spell] s.3235,3338 should not be removed on Evade (AnonXS) #628
• b885d29: [SD] Add missing Fire Shield Aura passive for c.9816 (AnonXS) #629
• 000cffe: [SD] Add SPELL_DOUBLE_ATTACK 19818 to sapphiron CombatAI (AnonXS) #631
• a864ef5: Add Maiden of Virtue texts to bct (Miraco) #632
• 3777cb1: Add maiden of Virtue to spell_list (Miraco) #632
• Add back bct on repentance (killerwife)
• 2ff85f7: [Spell] s.7131 - npc 2638,4785,5097,6493,6932,11027,11263 (AnonXS) #633
• 0905e8c: [SD][Spell] Add s.16331 Incorporeal Defense for mobs_spectral_ghostly_citizen (AnonXS)
• 0da6967: [Spell] Spore Burst 38471 should not be removed on Evade (AnonXS)
• 3cc96db: [Spell] Retching Plague 30079 should not be removed on Evade (AnonXS)
• Fix dialogue helper not working with BCTs (insunaa)
• 8e524e3: Fix #3480 Replace hardcoded gossip strings with database entries for localization (Scarabol) #644
• Add check for single target to resist/miss channeled spell cancel (David)
• Fix order of operations causing new dynguid fixes not working for active entities (killerwife)
• 21092b9: Null pointers check (gromchek)
• Fix Reginald Windsor script for 'The Masquerade' (insunaa)
• Allow secondary target checking for area auras (insunaa)
• Allow secondary target checking for area auras (insunaa)
• Add assert for double unsummon of same pet. (killerwife)
• Implement GetDamageForEffect for scripting purposes (killerwife)
• Add Unit::GetAura const (killerwife)
• Abstract m_usableWhileStunned (killerwife)
• Add support for randomized spawn groups prototype (killerwife)
• Mark SendCancelTrade as const (killerwife)
• Fix typo in merged sql for npc_lady_katrana_prestor (killerwife)
• Fix npc info parts not working with dynguid (killerwife)
• Make s.16093 use dead state not sleep (killerwife)
• Add const qualifiers to params to enable passing const strings (killerwife)
• Add errors for using same type dbGuid twice (killerwife)
• Fix missed truncate syntax update #652 (insunaa)
• 49d61a3: Shattered Halls - Shattered Hand Legionnaire script rework (cmangos#648) (_daanieL) #648
• d9bf405: Add some missing spells (killerwife)
• add missing spell_script, fix typo and add db handling for legionnaire 6 #654 (Miraco)
• 0947117: Spell/Unit: Disable charge proccing in proc system for spellmods (killerwife)
• Remove built in nagle algo and fully go async (cmangos#653) #653 (killerwife)
• e12327f: Realm/Core: Improve start script for mangosd and add realmd one (killerwife)
• Remove leftover printf (killerwife)
• d059f4c: Simplify memory management for loot template (Cyberium)
• 911e219: Simplify loot process call (Cyberium)
• cfac4d7: Remove debug lootdropstats command (Cyberium)
• f9878ae: Add loot command to ChatHandler (Cyberium)
• e59d3cb: Move loot entry check to more correct place (Cyberium)
• e010f42: Add stats support for 2 same item id in same loot entry. (Cyberium)
• b2ade5d: Should fix nix build (Cyberium)
• fb3bee4: Bump actions/download-artifact from 3 to 4 (dependabot[bot])
• 7ed5a3a: Bump actions/checkout from 3 to 4 (dependabot[bot])
• 12faed7: Bump rjstone/discord-webhook-notify from 1.0.4 to 1.1.1 (dependabot[bot])
• b4280b9: Bump actions/upload-artifact from 3 to 4 (dependabot[bot]) #657
• 0448896: Support expansion-specific XP modifiers (LunaticInAHat)
• c81fb7b: Generalize XP rate mod of previous commit and unify GetXPModRate call (Cyberium)
• Add missing init to npc_shaheenAI (killerwife)
• Prep npc_shaheenAI for spell list (MantisLord)
• Adjust motion type used by Nagmara & Rocknot (MantisLord)
• Port Judgement of Command to spellscript (MantisLord)
• 8c55e0a: Realmd/Core: Adjust username length to proper max length allowed during creation (killerwife)
• 35c803c: Fix compilation errors (Fonix) #658
• 2f13fea: Spell/Engineering: Goblin Bomb Dispenser (MantisLord)
• Fix typo causing threat multiplication on omrogg (killerwife)
• Reimplement SPELL_ATTR_SCALES_WITH_CREATURE_LEVEL using CLS as confirmed (killerwife)
• 90aff82: Fix NPC name in new mail notification when receiving mails from NPCs (Karth)
• 1b45aae: Fix type of last dword in MSG_QUERY_NEXT_MAIL_TIME (Cyberium)
• Fix compiler warnings #659 (insunaa)
• Safeguard go use which has lockId and should be used by spell (killerwife)
• 411ecb7: Add couple safeguards to ProcessIncomingData against crashes (killerwife)
• Add check against RequiredLevel for lootable items (robinsch)
• e9184f2: [s2473] Item: Adjust itemTextId in item_instance to correspond to packet, load and item_text width (killerwife)
• Implement CreatureLinkingAggroDelay (killerwife)
• Add missing error return clause to WorldSocket::ProcessIncomingData (killerwife)
• Do not disconnect session when packet cooldown is triggered (killerwife)
• Fix crash due to missing enemy safeguard (killerwife)
• Disable assistance call for critters (killerwife)
• Fix SCRIPT_COMMAND_OPEN_DOOR not working with dynguid (killerwife)
• Implement .worldstate set X Y (killerwife)
• Correct omrogg head spawning location (killerwife)
• Handle areatrigger for Ashbringer event (MantisLord)
• fix member initializer list. (evil-at-wow)
• dcbbffd: Fix memory leak, leaking a single script. (evil-at-wow)
• Add a couple missing captures (killerwife)
• 7fb0362: Bump MarkusJx/install-boost from 2.4.4 to 2.4.5 (dependabot[bot]) #661
• Implement SCRIPT_FLAG_COMMAND_ADDITIONAL for SCRIPT_COMMAND_CAST_SPELL to pass nullptr target (killerwife)
• Rework reconnection case to fix slow cpu race conditions (killerwife)
• 797bb7e: Add serverside spell Summon Captured Critter 35136 (MantisLord)
• f8fa7f4: Adjust CreatureFamilyAssistanceRadius being too big (killerwife)
• Add crash check and respawn fix against misuse of chat commands (killerwife)
• ac1053e: [s2474] Auth: Adjust joindate to be datetime (killerwife)
• Add back error handling from old code for packet header in mangosd (killerwife)
• a7caaba: Tools/MMaps: Fixed a suspicious bitwise condition. (killerwife)
• 61990fb: [s2475] Use bonus coefficient data from spell_template/DBC (MantisLord) #664
• 8b24e51: Roll spell_template into Spell.sql (killerwife)
• Fix EffectSummonType always overriding level for wild spawns (killerwife)
• b4f6b4b: [s2476] Spell: Also add AP columns and functionality (killerwife)
• Reimplement Creature::LockOutSpells with CreatureStaticFlags2::NO_INTERRUPT_SCHOOL_COOLDOWN (killerwife)
• Fix ambassador hellmaw going banished on reset (killerwife)
• Add afk kick after 15 minutes back in (killerwife)
• Remove redundant payload of SMSG_AUTH_CHALLENGE (killerwife)
• 0a00e98: Move Log to its own folder to avoid possible issues with g3dlite log.h (Cyberium)
• c5e25dc: Rename BUILD_PLAYERBOT option to BUILD_DEPRECATED_PLAYERBOT (Cyberium)
• Add flag usage to SMSG_SPELL_COOLDOWN instead of random value (killerwife)
• Implement caster and target flag skip from attributes (killerwife)
• Implement usage of restriction skip attributes for basic things (killerwife)
• 62cb97a: Playerbots integration (Flekz) #666
• 2c4c302: fix ProcSystemArguments constructor arg mismatch (cdkr) #667
• e903525: [Quest] rework Missing in Action quest using new systems (cmangos#660) (_daanieL) #660
• Implement CREATURE_GROUP_FORMATION_MIRRORING (killerwife)
• Implement config override with env vars (cmangos#502) (Anton Popovichenko)
• Tryfix double unsummon crash due to visibility (killerwife)
• 6d2e80d: [Quest] modernize defias brotherhood escort quest (killerwife)
• 271276f: [Quest] modernize 'Protect the Shipment' escort quest (Miraco)
• 981dc7a: Remove gameobject los temp fix for playerbots (Flekz)
• Extend Support for new MacOS Versions (+Apple Silicon) (insunaa)
• Fix compilation for pch on linux (killerwife)
• Minor rework of code to make it same as wotlk (killerwife)
• 661fba1: Move spell to proper section (killerwife)
• Fix MacOS/Apple Silicon compile (insunaa)
• f2798ea: Spell/Unit: Remove now redundant default coeff calculation (killerwife)
• Add ignore los to shirrak inhibit magic aoe (killerwife)
• Fix grid loading issue (cmangos#536) - Exxenoz (Flekz)
• 161d94b: Spell/Unit: Fix default for coefficient being 0 and fix coeff for npc pets (killerwife)
• Handle spell item requirements by the bot system (Flekz)
• b788607: [s2477] Creature: Add CharmedSpellList shorthand during charm (killerwife)
• Move durability loss logic into bot method (Flekz)
• Implement partially generalized example for triggering events based on locations player enter (killerwife)
• Add missing files in previous commit (killerwife)
• Fix ::AddInstanceEvent only going off once (killerwife)
• 5a6e5dc: Add missing table to creature_template due to alter table (killerwife)
• Do not trigger ::AddInstanceEvent as GM (killerwife)
• 53a3801: Chat/GM: Add unkillable command (insunaa)
• e03f672: Fix failed cherry-pick (insunaa)
• Add usage of SPELL_ATTR_EX3_IGNORE_CASTER_AND_TARGET_RESTRICTIONS to checking immune on target (killerwife)