Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yomu & spectral #7363

Closed
wants to merge 1 commit into from
Closed

Conversation

Hellkaros
Copy link
Contributor

@Hellkaros Hellkaros commented Jan 27, 2025

Closes #7349
Closes #7340
Closes #7357

To the users: migrate from sssscanlator to yomucomics.

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@choppeh
Copy link
Contributor

choppeh commented Jan 27, 2025

Add id to YomuComics(SSSScanlator): 1497838059713668619

https://github.com/keiyoushi/extensions/blob/012ba80ae876f207a9d8c95c9490919e4f8bf80f/index.json#L24101

Old urls are compatible with the new URL after rebrading. And old domain is still working

override val id = 1497838059713668619

baseUrl = 'https://ssstoons.com'
overrideVersionCode = 4
baseUrl = 'https://yomucomics.com'
overrideVersionCode = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump version

Suggested change
overrideVersionCode = 0
overrideVersionCode = 5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in this case, I created a new directory for yomu, it's not a continuation of the sss directory. Doesn't it have to start with 0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in this case, I created a new directory for yomu, it's not a continuation of the sss directory. Doesn't it have t

As chopper said, they just changed the name and domain, so the "overrideVersionCode" goes to number 5 (as if it were a website update).

@choppeh
Copy link
Contributor

choppeh commented Jan 27, 2025

Tip 💡: Avoid mixing different contexts in the same PR

@Hellkaros
Copy link
Contributor Author

Add id to YomuComics(SSSScanlator): 1497838059713668619

https://github.com/keiyoushi/extensions/blob/012ba80ae876f207a9d8c95c9490919e4f8bf80f/index.json#L24101

Old urls are compatible with the new URL after rebrading. And old domain is still working

override val id = 1497838059713668619

Here it falls into the same aspect as the context below, wouldn't yomu be something different from SSS? Shouldn't it have its own ID?

@deividgabrielpeira
Copy link
Contributor

Here it falls into the same aspect as the context below, wouldn't yomu be something different from SSS? Shouldn't it have its own ID?

Old urls are compatible with the new URL after rebrading. And old domain is still working

Your "PR" will not be approved. I recommend that you create your own SSS PR for Yomu, another for Spectral, and another to delete the extensions that do not work.

It is not recommended to mix things from: "add, remove and update".

@Hellkaros Hellkaros closed this Jan 27, 2025
@Hellkaros Hellkaros deleted the pt-yomucomics branch January 27, 2025 18:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants