-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yomu & spectral #7363
Add yomu & spectral #7363
Conversation
Add id to YomuComics(SSSScanlator): 1497838059713668619 Old urls are compatible with the new URL after rebrading. And old domain is still working override val id = 1497838059713668619 |
baseUrl = 'https://ssstoons.com' | ||
overrideVersionCode = 4 | ||
baseUrl = 'https://yomucomics.com' | ||
overrideVersionCode = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump version
overrideVersionCode = 0 | |
overrideVersionCode = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in this case, I created a new directory for yomu, it's not a continuation of the sss directory. Doesn't it have to start with 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in this case, I created a new directory for yomu, it's not a continuation of the sss directory. Doesn't it have t
As chopper said, they just changed the name and domain, so the "overrideVersionCode" goes to number 5 (as if it were a website update).
Tip 💡: Avoid mixing different contexts in the same PR |
Here it falls into the same aspect as the context below, wouldn't yomu be something different from SSS? Shouldn't it have its own ID? |
Your "PR" will not be approved. I recommend that you create your own SSS PR for Yomu, another for Spectral, and another to delete the extensions that do not work. It is not recommended to mix things from: "add, remove and update". |
Closes #7349
Closes #7340
Closes #7357
To the users: migrate from sssscanlator to yomucomics.
Checklist:
extVersionCode
value inbuild.gradle
for individual extensionsoverrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsisNsfw = true
flag inbuild.gradle
when appropriateid
if a source's name or language were changedweb_hi_res_512.png
when adding a new extension