Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pre and post sort logic if script starts with "-" #49

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

Americas
Copy link
Contributor

@Americas Americas commented Nov 9, 2018

Use case:

Having prescript, postscript and script should sort based on script, just as it is now. This follows the logic that calling script will behind the scenes call prescript and postscript.

Having pre-script or post-script won't be called when calling script, it will if you call -script, but that makes little sense, I don't think anyone would do that.

With that in mind, I suggest tweaking the sort algorithm to ignore these cases so they can be sorted into their natural places.

@keithamus keithamus merged commit ccbc536 into keithamus:master Nov 9, 2018
@waldyrious waldyrious mentioned this pull request Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants