Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no-regexp-s-flag crash on non-string flags #2

Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix: no-regexp-s-flag crash on non-string flags #2

merged 1 commit into from
Feb 5, 2020

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Feb 4, 2020 •
edited
Loading

Second argument type is not checked. Cause eslint crash on Identifier

Only allow Literal and TemplateLiteral,

TemplateLiteral should not very offen to see, but not very hard to add this check, so I added it.

keithamus
keithamus approved these changes Feb 5, 2020
View reviewed changes
Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch! Thanks @fisker 😄

@keithamus keithamus merged commit 4c53824 into keithamus:master Feb 5, 2020
@keithamus
Copy link
Owner

🎉 Published as 2.1.3

https://github.com/keithamus/eslint-plugin-escompat/releases/tag/v2.1.3

@fisker fisker deleted the fix-no-regexp-s-flag branch February 5, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @keithamus