Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revised initialization #1

Merged
merged 1 commit into from
Oct 9, 2021
Merged

revised initialization #1

merged 1 commit into from
Oct 9, 2021

Conversation

zaki50
Copy link
Contributor

@zaki50 zaki50 commented Oct 9, 2021

以下の3点を修正しました。

  • TABLE_DECODETABLE_DECODE_URL_SAFEの長さをASCIIコード全体を保持できる 128(1 << 7) に変更した
  • TABLE_DECODETABLE_DECODE_URL_SAFEの初期値のセットをループではなく Arrays.fill() を使うように変更した
  • TABLE_DECODETABLE_DECODE_URL_SAFEの構築をTABLE_ENCODETABLE_ENCODE_URL_SAFEを用いることでハードコードされている値を除去した

Copy link
Owner

@keiji keiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keiji keiji merged commit a896afa into keiji:main Oct 9, 2021
@zaki50 zaki50 deleted the my/initialization branch October 9, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants