-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending lots of love ❤️ #374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2020
Holy macaroni Frenck! Let's see if we can make it to a release tonight, starting now! |
keesschollaart81
requested changes
Jul 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of checks. Mostly because of some schema errors in test-configurations I have around.
keesschollaart81
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly @keesschollaart81, I love this extension. It brings so much awesomeness to people who maintain their YAML configuration files manually... it is insane!
So thank you for that 🙏
This PR is lending a hand in bringing it to other levels and further future extension of this beauty.
⚠️ It is a big one, so this needs quite a bit of testing.
In this PR:
vscode
is removed and replaced with just the types andvscode-test
.entity_id: -
npm run lint
(or individually:lint:types
,lint:eslint
,lint:prettier
)npm run format
(or individually:format:eslint
,format:prettier
)husky
andlint-staged
(to ensure only git staged files are linted).await
was used in for-loops.fixes #288 fixes #326 fixes #371 fixes #296 fixes #340 fixes #360 closes #351 closes #358 closes #363 closes #337 closes #330 closes #328 closes #367 closes #370 closes #366 closes #365 closes #364 closes #342 closes #332
Furthermore opened up an PR @ Prettier, to support the
home-assistant
language.prettier/prettier#8739
Starting points from here would be: