Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add availability option to mqtt integration #2168

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Add availability option to mqtt integration #2168

merged 1 commit into from
Sep 16, 2022

Conversation

piitaya
Copy link
Contributor

@piitaya piitaya commented Jun 13, 2022

The option was here but value_template was missing.
I also refactored the code with an Availability type.

@piitaya piitaya changed the title fix(mqtt): add availability option to mqtt integration Add availability option to mqtt integration Jun 14, 2022
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2022
@frenck frenck removed the wontfix This will not be worked on label Sep 16, 2022
frenck
frenck approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @piitaya 👍

@frenck frenck merged commit 8c3cbcc into keesschollaart81:dev Sep 16, 2022
@piitaya piitaya deleted the feat/mqtt_availability branch September 16, 2022 14:10
@frenck frenck added the enhancement New feature or request label Dec 12, 2022
@frenck frenck mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piitaya @frenck