Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove word recovery #182

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Remove word recovery #182

merged 2 commits into from
Nov 25, 2019

Conversation

keepkeyjon
Copy link
Contributor

It takes up space in .text/.data/.bss, and isn't being used.

@keepkeyjon keepkeyjon requested a review from solipsis October 19, 2019 17:57
@keepkeyjon
Copy link
Contributor Author

https://github.com/keepkey/python-keepkey/pull/80/files

@keepkeyjon
Remove word recovery
efea76a 
It takes up space in .text/.data/.bss, and isn't being used.
@keepkeyjon
update python-keepkey
12d22c2
solipsis
solipsis approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@solipsis solipsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Free those bytes

@keepkeyjon keepkeyjon merged commit 2f3d210 into master Nov 25, 2019
@keepkeyjon keepkeyjon deleted the remove-word-recovery branch November 25, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solipsis solipsis solipsis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keepkeyjon @solipsis