On case-sensitive OS, force use of lowercase config directory

[droidmonkey]

• Use the native application name for the config folder versus the camel-case name defined later
• Fixes Applications settings lost after moving from stable to git #4835

Screenshots

Testing strategy

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[phoerious]

I would like to restrict this to Linux. Windows and macOS should use camelCase/PascalCase.

[droidmonkey]

Fine by me

[yan12125]

How about using QStandardPaths::GenericConfigLocation and appending '/keepassxc' instead of using QStandardPaths::AppConfigLocation [1] and bothering with the application initialization order?

[1]

keepassxc/src/core/Config.cpp

Line 447 in c68f487

configPath = QDir::fromNativeSeparators(QStandardPaths::writableLocation(QStandardPaths::AppConfigLocation));

[phoerious]

That would have been my fix for this issue.

[droidmonkey]

That is fine by me for Linux only, you said you wanted Windows and macOS to use CamelCase.

[PsikoBlock]

Don't forget that it's possible to use a case-sensitive filesystem on macOS as well. It would be better to disable this only on Windows.

[phoerious]

Possible, but rare. All sorts of applications start breaking down it you make your system fs case-sensitive.

[droidmonkey]

I fixed the implementation, should be ready for merge now

[yan12125]

Thanks! I can confirm with this patch, application settings are preserved when upgrading KeePassXC from 2.5.4 to 2.6.