Cleanup welcome screen recent databases view #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
approved these changes
Jun 5, 2020
|
I think there is still this bug that the field stays visible after clearing out all entries. That should be fixed as well. |
droidmonkey
approved these changes
Jun 5, 2020
|
We can merge this into 2.6.0, it is a glaring UI issue. Thank you for the submission! |
|
Thanks :) |
droidmonkey
changed the title
lerignoux
pushed a commit
to lerignoux/keepassxc
that referenced
this pull request
Jul 20, 2020
* Press "Delete" to remove recent database * Refresh recent databases on becoming visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a database in the "Recent databases" on the welcome screen is selected, pressing the "Delete" key will now cause that database to be removed from the recent databases list.
Fixes #4710
Additionally, this fixes a segfault that occurs when a user presses Enter while the "Recent databases" widget is in focus but no database is selected.
Screenshots
Testing strategy
I did some manual tests.
I'm new to this so let me know if/how I should implement tests.
Type of change