Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with HIBP report #4531

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix issues with HIBP report #4531

merged 1 commit into from
Apr 8, 2020

Conversation

droidmonkey
Copy link
Member

Type of change

  • ✅ Bug fix (non-breaking change which fixes an issue)

Description and Context

  • Show horizontal header in results table
  • Correctly handle the case when there are no entries to analyze
  • Make countToText static

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ My change requires a change to the documentation, and I have updated it accordingly.
  • ✅ I have added tests to cover my changes.

@droidmonkey
Fix issues with HIBP report
5e236d3 
* Show horizontal header in results table
* Correctly handle the case when there are no entries to analyze
* Make countToText static
@droidmonkey droidmonkey added this to the v2.6.0 milestone Apr 1, 2020
@droidmonkey droidmonkey requested a review from phoerious April 1, 2020 00:53
@droidmonkey droidmonkey mentioned this pull request Apr 1, 2020
Closed
@droidmonkey droidmonkey merged commit ab9856e into develop Apr 8, 2020
@droidmonkey droidmonkey deleted the fix/hibp-report branch April 8, 2020 16:51
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoerious phoerious phoerious approved these changes

Assignees
No one assigned
Labels
feature: Reports pr: bugfix Pull request that fixes a bug
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@droidmonkey @phoerious