CLI: Cleanup create options

[louib]

Fixes #4307

This makes sure that there's no clash between the database opening options (--no-password and --key-file) and the database creation/modification options, which start by --set. The main consequence is that setting the password on creation must be done explicitly, but I feel like it's ok to be explicit when creating the db.

Type of change

• ✅ Refactor (significant modification to existing code)
• ✅ New feature (non-breaking change which adds functionality)
• ✅ Breaking change (fix or feature that would cause existing functionality to change)
• ✅ Documentation (non-code change)

Testing strategy

unit tests.

Checklist:

• ✅ I have read the CONTRIBUTING document. [REQUIRED]
• ✅ My code follows the code style of this project. [REQUIRED]
• ✅ All new and existing tests passed. [REQUIRED]
• ✅ My change requires a change to the documentation, and I have updated it accordingly.
• ✅ I have added tests to cover my changes.

[droidmonkey]

If neither --set-password nor --set-keyfile are provided we should add a prompt to confirm that the user intends to create a database without any protection. This prompt would not show if the --quiet flag is set.

[louib]

If neither --set-password nor --set-keyfile are provided we should add a prompt to confirm that the user intends to create a database without any protection. This prompt would not show if the --quiet flag is set.

Can we create a database without any protection from the GUI?

[droidmonkey]

Yes you can, but it gives you a warning

[louib]

@droidmonkey of course we could also preserve the current default of creating the db with a password. Not sure what is the best solution here.

[droidmonkey]

I'm confused, can't we just do:

if (!parser->isSet(Command::SetKeyFileOption) 
    && !parser->isSet(Command::SetPasswordOption) 
    && !parser->isSet(Command::NoCredentialsOption)) {

	err << QObject::tr("Cannot create database without any credentials. If this is what you intended to do, use --set-no-credentials.");
	return EXIT_FAILURE;
}

[louib]

@droidmonkey yeah, we could 💯% do this.

[droidmonkey]

@louib are you going to complete this PR?

[louib]

@droidmonkey yes, I'm going to need a couple more weeks before I can jump back into it.

[droidmonkey]

I can complete this one to get it off the books, otherwise it might not make 2.6

[droidmonkey]

So you cannot create a database with no credentials in the GUI so I did not allow that behavior in CLI. I did, however, implement password repeat checks and the ability to create a database without a password. This applies to the import command as well.

[louib]

@droidmonkey so you decided not to implement a --no-credentials option? I don't mind the Y/N question, but I feel like it makes the process less suitable for scripting.

[droidmonkey]

That is only for a blank password. It is no less scriptable than having to enter a password in the first place. It would be very niche to me to script database creation or importing from xml/csv.