Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passphrase word lists not rendering with UTF-8 #11602

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

droidmonkey
Copy link
Member

Screenshots

BEFORE:
image

AFTER:
image

Testing strategy

Tested manually

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added pr: bugfix Pull request that fixes a bug feature: Password Generator labels Dec 27, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.87%. Comparing base (e76e9d4) to head (3319b9a).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11602      +/-   ##
===========================================
+ Coverage    63.84%   63.87%   +0.03%     
===========================================
  Files          362      362              
  Lines        38169    38170       +1     
===========================================
+ Hits         24368    24379      +11     
+ Misses       13801    13791      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey merged commit fb022cb into develop Dec 27, 2024
11 checks passed
@droidmonkey droidmonkey deleted the fix/passphrase-utf-8 branch December 27, 2024 23:06
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Password Generator pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display of words from a custom wordlist seems jumbled up.
2 participants