Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering & and " in password preview #11594

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

droidmonkey
Copy link
Member

Forgot to include this fix based on discussion in #11538 (comment)

Testing strategy

Tested before/after, code change correctly shows password

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added the pr: bugfix Pull request that fixes a bug label Dec 24, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.90%. Comparing base (af0c164) to head (3354bd6).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/EntryPreviewWidget.cpp 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11594      +/-   ##
===========================================
- Coverage    63.90%   63.90%   -0.00%     
===========================================
  Files          362      362              
  Lines        38153    38155       +2     
===========================================
+ Hits         24380    24381       +1     
- Misses       13773    13774       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey
Copy link
Member Author

Actually need to fix it in the title field as well

@phoerious
Copy link
Member

Maybe check all the other places as well, also the ones where we already escape. It either needs to be HTML escaping with HTML formatting on or plain text. But HTML escaping with auto format will break.

@droidmonkey
Copy link
Member Author

Yup agree

* Set plain text mode on elements that should never have styling
* Revert html escaping as a prior fix
@droidmonkey droidmonkey force-pushed the fix/html-escape-preview branch from 984d4e4 to 3354bd6 Compare December 26, 2024 02:19
@droidmonkey
Copy link
Member Author

@phoerious this is ready to go:

image

@droidmonkey droidmonkey merged commit 17dc022 into develop Jan 6, 2025
11 checks passed
@droidmonkey droidmonkey deleted the fix/html-escape-preview branch January 6, 2025 11:23
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants