Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning in case any of the slots are not configured #11544

Conversation

payloadartist
Copy link

@payloadartist payloadartist commented Dec 8, 2024

Fixes #11543 by adding a warning message in Qt when any of the slots aren't configured.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@payloadartist payloadartist marked this pull request as ready for review December 8, 2024 17:52
@droidmonkey
Copy link
Member

This is fine but not a solution to the problem because you need to be monitoring the console to see it. Prefer a smarter message be displayed on the open widget.

@payloadartist payloadartist marked this pull request as draft December 8, 2024 18:25
@droidmonkey
Copy link
Member

I'm thinking of something like: "Hardware keys found, but no slots are configured"

@payloadartist
Copy link
Author

payloadartist commented Dec 9, 2024

@droidmonkey indeed that message is more intuitive. 2 points:

  • what if we have multiple YubiKeys for work and personal? I feel serial should be also shown
  • what if the other slot is misconfigured? there are two slots, long and short press so we need to convey the same to the user for better debugging

cheers

@droidmonkey
Copy link
Member

This message would only show if:

  1. One or more hardware keys are detected
  2. None of them have slots configured for challenge-response use

During this scenario it doesn't matter what the serial numbers are of the keys, we are letting the user know that none of them are setup for KeePassXC. The console message shows more detailed detection information if they so desire.

If a user has at least one key/slot properly configured it is assumed they know how to do it and they know what they are doing.

@payloadartist
Copy link
Author

Thanks @droidmonkey, makes sense!

@droidmonkey
Copy link
Member

This is being implemented under #11609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate when Hardware Keys are found but no slots are configured
2 participants