Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default size of Auto-Type selection dialogue #5361

Closed
mwip opened this issue Aug 31, 2020 · 1 comment · Fixed by #5864
Closed

Set default size of Auto-Type selection dialogue #5361

mwip opened this issue Aug 31, 2020 · 1 comment · Fixed by #5864
Assignees
@droidmonkey
Labels
feature: Auto-Type user interface
Milestone
v2.7.0

Comments

@mwip
Copy link

mwip commented Aug 31, 2020

I want to propose a feature (if it is not already there and I just didn't find it). My window manager (Xmonad) always shrinks the Auto-Type selection dialogue. I tried to set it to a specific size from the WM side but it seems that KeePassXC overrules the floating window rules I set.

image

Is there any way to set the default size of the Auto-Type selection dialogue? I found the section AutoTypeSelectDialogSize=@Size(554 155) in .cache/keepassxc/keepassxc.ini and tried to change it, but this will be overwritten when I trigger Auto-Type.

Would it be possible to add a setting, possibly in the Auto-Type settings, to set the default Auto-Type dialogue size?

Systeminfo (Private and Work):
Arch Linux && Ubuntu 18.04
Xmonad 0.15 && Xmonad 0.13
KeePassXC 2.6.1
@droidmonkey droidmonkey added this to the v2.7.0 milestone Aug 31, 2020
@droidmonkey droidmonkey self-assigned this Aug 31, 2020
@droidmonkey
Copy link
Member

Resizing the window to fit the contents is desired behavior, but it should not cut off the list. Will be fixed as part of Auto-Type overhaul.

droidmonkey added a commit that referenced this issue Dec 2, 2020
@droidmonkey
Improve Auto-Type Select Dialog
d16bbfb 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
droidmonkey added a commit that referenced this issue Dec 3, 2020
@droidmonkey
Improve Auto-Type Select Dialog
45dd1ef 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
droidmonkey added a commit that referenced this issue Dec 17, 2020
@droidmonkey
Improve Auto-Type Select Dialog
0c9c841 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
droidmonkey added a commit that referenced this issue Dec 24, 2020
@droidmonkey
Improve Auto-Type Select Dialog
95f445e 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
@droidmonkey droidmonkey mentioned this issue Dec 24, 2020
Merged
2 tasks
droidmonkey added a commit that referenced this issue Dec 26, 2020
@droidmonkey
Improve Auto-Type Select Dialog
0fbd16b 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
droidmonkey added a commit that referenced this issue Feb 14, 2021
@droidmonkey
Improve Auto-Type Select Dialog
87ff43f 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
droidmonkey added a commit that referenced this issue Feb 15, 2021
@droidmonkey
Improve Auto-Type Select Dialog
23ccc6f 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
droidmonkey added a commit that referenced this issue Feb 22, 2021
@droidmonkey
Improve Auto-Type Select Dialog
d9ae449 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix #5361 - Default size of selection dialog doesn't cut off matches
libklein pushed a commit to libklein/keepassxc that referenced this issue Mar 1, 2021
@droidmonkey @libklein
Improve Auto-Type Select Dialog
4a720ed 
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths.

* Close select dialog when databases are locked.
* Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference.
* Never perform Auto-Type on the KeePassXC window.
* Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column)
* Always show the sequence column (revert feature)
* Show selection dialog if there are no matches to allow for a database search

* Close keepassxreboot#3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu).
* Close keepassxreboot#429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
* Fix keepassxreboot#5361 - Default size of selection dialog doesn't cut off matches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
feature: Auto-Type user interface
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

Major improvements to Auto-Type keepassxreboot/keepassxc
2 participants
@droidmonkey @mwip