Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database write issues when database is on an automounted device #3985

Closed
ckastner opened this issue Dec 7, 2019 · 2 comments
Closed

Database write issues when database is on an automounted device #3985

ckastner opened this issue Dec 7, 2019 · 2 comments

Comments

@ckastner
Copy link

ckastner commented Dec 7, 2019

On a Debian 10 system with KeePassXC 2.4.3, I'm seeing two kinds of problems when the database is on an automounted device:

  1. When adding a new entry, after confirming with [OK], the entry is sometimes not added to the group (and no change of database is detected, "Save" remains inactive)
  2. The entry is added after confirming with [OK], but then a "Merge request" dialog pops up (because the underlying database has changed).

I can see that systemd.automount is repeatedly mounting and unmounting the device.

If I force the directory to remain mounted (eg by opening the directory in a file browser), the issue disappears.

I'm guessing that KeePassXC reads the database in its entirety upon startup, then closes it again, only to open it again when a writeout needs to happen, all while periodically checking whether the underlying file has changed?

Here is an example fstab entry:
UUID=xxx /media/foo ext4 noauto,x-systemd.automount,x-systemd.idle-timeout=3 0 0

Possible Solution

An option to force the database (or even just the underlying directory) to remain in use would be nice.

Debug Info

KeePassXC - Version 2.4.3
Revision: 5d6ef0c

Qt 5.11.3
Debugging mode is disabled.

Operating system: Debian GNU/Linux 10 (buster)
CPU architecture: x86_64
Kernel: linux 5.3.0-0.bpo.2-amd64

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (only unsigned sharing)
  • YubiKey

Cryptographic libraries:
libgcrypt 1.8.4

@ckastner ckastner added the bug label Dec 7, 2019
@droidmonkey
Copy link
Member

Upgrade to 2.5.1 and you'll be all set.

@droidmonkey droidmonkey removed the bug label Dec 7, 2019
droidmonkey added a commit that referenced this issue May 10, 2020
* Fix #3790, shares now use the standard FileWatcher class to detect remote file changes using checksums and file system triggers.

* Fix #3985, macOS file selection no longer hangs the app.

* Restore saving of KeeShare settings accidentally removed by 596d2cf
droidmonkey added a commit that referenced this issue May 10, 2020
* Fix #3790, shares now use the standard FileWatcher class to detect remote file changes using checksums and file system triggers.

* Fix #3985, macOS file selection no longer hangs the app.

* Restore saving of KeeShare settings accidentally removed by 596d2cf
droidmonkey added a commit that referenced this issue May 10, 2020
* Fix #3790, shares now use the standard FileWatcher class to detect remote file changes using checksums and file system triggers.

* Fix #3985, macOS file selection no longer hangs the app.

* Restore saving of KeeShare settings accidentally removed by 596d2cf
droidmonkey added a commit that referenced this issue May 10, 2020
* Fix #3790, shares now use the standard FileWatcher class to detect remote file changes using checksums and file system triggers.

* Fix #3985, macOS file selection no longer hangs the app.

* Restore saving of KeeShare settings accidentally removed by 596d2cf
droidmonkey added a commit that referenced this issue May 10, 2020
* Fix #3790, shares now use the standard FileWatcher class to detect remote file changes using checksums and file system triggers.

* Fix #3985, macOS file selection no longer hangs the app.

* Restore saving of KeeShare settings accidentally removed by 596d2cf
droidmonkey added a commit that referenced this issue May 10, 2020
* Fix #3790, shares now use the standard FileWatcher class to detect remote file changes using checksums and file system triggers.

* Fix #3985, macOS file selection no longer hangs the app.

* Restore saving of KeeShare settings accidentally removed by 596d2cf
@ckastner
Copy link
Author

Apologies for the late reply, I didn't get around to testing the newest version back then.

2.5.4 was released as a backport in Debian recently, and I just wanted to confirm that it indeed fixed the issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants