Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use ERC20 component #26

Merged
merged 3 commits into from
Dec 13, 2023
Merged

refactor: use ERC20 component #26

merged 3 commits into from
Dec 13, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Dec 13, 2023

  • Refactors to use ERC20 components
  • Entrypoints imported from components are only ERC20Metadata as, I think we're going to modify the other ones
  • We, however, use internals from ERC20Internal in our custom entrypoints
  • The _transfer function is redfined in an Internal impl, because we will very likely use a custom one
  • Integration of all the entrypoints, embedded or not, is tested.

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unruggable-memecoin ❌ Failed (Inspect) Dec 13, 2023 10:04am

AbdelStark
AbdelStark approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbdelStark AbdelStark merged commit e4153cc into main Dec 13, 2023
5 of 6 checks passed
@0xChqrles 0xChqrles deleted the refactor/components branch April 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelStark AbdelStark AbdelStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @AbdelStark