feat: implement maximum holders before launch safeguard #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
credence0x
changed the title
enitrat
reviewed
Dec 13, 2023
AbdelStark
reviewed
Dec 14, 2023
| @@ -173,6 +195,19 @@ mod UnruggableMemecoin { | |||
| amount: u256 | |||
| ) -> bool { | |||
| let caller = get_caller_address(); | |||
|
|
|||
| if self.launched.read() == false { | |||
There was a problem hiding this comment.
can you please try to factorise the code ? it's the same block as the one in transfer function
|
|
||
|
|
||
| #[test] | ||
| fn test_transfer() { |
There was a problem hiding this comment.
please have more explicit names for the test functions
| @@ -91,11 +97,18 @@ mod UnruggableMemecoin { | |||
| // ************************************ | |||
| // * UnruggableMemecoin functions | |||
| // ************************************ | |||
|
|
|||
| fn launched(self: @ContractState) -> bool { | |||
contracts/src/tokens/memecoin.cairo
Outdated
| @@ -171,12 +184,32 @@ mod UnruggableMemecoin { | |||
| // | |||
| #[generate_trait] | |||
| impl UnruggableMemecoinInternalImpl of UnruggableMemecoinInternalTrait { | |||
| #[inline(always)] | |||
| fn _check_holders_limit(ref self: ContractState) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement maximum holders before launch safeguard #4