Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: disable multicall prevention after delay has passed #110

Merged
merged 1 commit into from
Jan 1, 2024
Merged

FEAT: disable multicall prevention after delay has passed #110

merged 1 commit into from
Jan 1, 2024

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Dec 30, 2023 •
edited
Loading

This PR disallows ensure_not_multicall if transfer_delay after launch has passed.

Closes #107

@vercel Vercel
Copy link

vercel bot commented Dec 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unruggable-memecoin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2024 4:17pm

@TAdev0
Copy link
Contributor Author

TAdev0 commented Dec 30, 2023

@enitrat i guess my test might need a refactor

@enitrat
Copy link
Collaborator

enitrat commented Jan 1, 2024

@TAdev0 I will review this after mergin the big stack of refactoring as I don't want to add too much rebasing conflicts

@enitrat enitrat force-pushed the disable_multicall_after_delay branch from 0267717 to 8585975 Compare January 1, 2024 16:16
enitrat
enitrat approved these changes Jan 1, 2024
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, I refactored the test while fixing the rebase conflicts

@enitrat enitrat merged commit 54d129d into keep-starknet-strange:main Jan 1, 2024
4 checks passed
@TAdev0
Copy link
Contributor Author

TAdev0 commented Jan 1, 2024

Great, thanks !

@TAdev0
Copy link
Contributor Author

TAdev0 commented Jan 1, 2024 •
edited
Loading

@enitrat Just one thing for the test :

        start_warp(
            CheatTarget::One(memecoin.contract_address), launch_timestamp + TRANSFER_LIMIT_DELAY + 1
        );

Here, +1 is not necessary as the multicall is disallowed if current_time >= (launch_time + transfer_delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: disable tx_hash tracker after a certain delay
2 participants
@TAdev0 @enitrat