Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean memecoin impl #105

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Dec 29, 2023

  1. Cleans the implementation of memecoin:
  • Removes legacy code
  • Apply clean code good practices
  • Correctly separate different concerns in different functions
  • Remove deadline parameter to supply to the AMM router (its in the same block anyway 😵 )
  1. Make transfer_limit_delay a parameter upon launch

  2. Clear tests from useless tests (e.g testing that transferFrom fails when allowance is too low)

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unruggable-memecoin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2023 9:15pm

feat: make transfer_limit_delay a parameter
feat: PercentageMath library
Copy link
Contributor

@0xEniotna 0xEniotna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@enitrat enitrat merged commit ab75dd2 into main Jan 1, 2024
6 checks passed
@0xChqrles 0xChqrles deleted the refactor/clean-memecoin-impl branch April 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants