Local devnet: fix block 10 #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftheirs
force-pushed
the
ft/fix_block_10_devnet
branch
from
f3f701d to
62f60ba
Compare
ftheirs
force-pushed
the
ft/fix_block_10_devnet
branch
from
62f60ba to
56a30d2
Compare
GMKrieger
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor fix. For block 10 onwards, we are able to compute old block as
block_number - STORED_BLOCK_HASH_BUFFERPathfinder reference: https://github.com/Moonsong-Labs/pathfinder/blob/c45b23d2d6407079ad19f84ef0b23f913063d7cd/crates/executor/src/execution_state.rs#L132-L152
Issue Number: N/A
Type
Description
Breaking changes?