-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: patch package gesture handler #42
chore: patch package gesture handler #42
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3ba8a41
to
703b2a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why we change the isEqual implemention to a custom one, was there an error with lodash version?
Also we recently moved from npm to yarn, postinstall-postinstall
package can optionally be installed.
Other than that LGTM
software-mansion/react-native-gesture-handler#2916 This was an error coming on an ios device (not simulator) so i looked into it and saw that software mansion team is also removing this too from their code so i decided that if we do too then this error will also go away. The error comes from this specific function inside lodash itself. |
I would need a test for ios device and android for this one tho. |
Thanks for the PR! I've just added postinstall package for yarn and merged. |
No description provided.