Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch package gesture handler #42

Conversation

ayushtom
Copy link
Contributor

No description provided.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 9:37am
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 9:37am

Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why we change the isEqual implemention to a custom one, was there an error with lodash version?
Also we recently moved from npm to yarn, postinstall-postinstall package can optionally be installed.
Other than that LGTM

@ayushtom
Copy link
Contributor Author

software-mansion/react-native-gesture-handler#2916

This was an error coming on an ios device (not simulator) so i looked into it and saw that software mansion team is also removing this too from their code so i decided that if we do too then this error will also go away. The error comes from this specific function inside lodash itself.

Screenshot 2024-05-24 at 3 03 50 PM

@ugur-eren ugur-eren merged commit d167f88 into keep-starknet-strange:main May 24, 2024
8 checks passed
@ayushtom
Copy link
Contributor Author

I would need a test for ios device and android for this one tho.
The earlier build errors didn't come on my personal device and simulator hence this might be needed

@ugur-eren
Copy link
Collaborator

Thanks for the PR! I've just added postinstall package for yarn and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants