Relay entry BLS verification #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngrinkevich
force-pushed
the
relay-entry-bls-verification-updated
branch
from
596a9ed to
5970005
Compare
|
@ngrinkevich How do we look here? Is it ready for review/testing? |
@pdyraga it is yeah |
pdyraga
reviewed
Mar 6, 2019
ngrinkevich
force-pushed
the
relay-entry-bls-verification-updated
branch
from
d73cf7f to
9534fee
Compare
On-chain verification expects compressed G1 point due gas optimization.
ngrinkevich
force-pushed
the
relay-entry-bls-verification-updated
branch
from
383c0df to
24b3cbc
Compare
This number should match the number of the polynomial coefficients created at the beginning of the DKG protocol.
ngrinkevich
force-pushed
the
relay-entry-bls-verification-updated
branch
from
24b3cbc to
8c32122
Compare
pdyraga
requested changes
Mar 8, 2019
|
|
||
| // Initialize Keep Group contract | ||
| minimumStake = 200000; | ||
| groupThreshold = 15; | ||
| groupSize = 20; | ||
| timeoutInitial = 20; | ||
| timeoutSubmission = 40; | ||
| timeoutSubmission = 50; |
There was a problem hiding this comment.
Why did we have to increase this value?
There was a problem hiding this comment.
this was the tweak to make group selection work on initialize in js tests, irrelevant now since I'm removing runGroupSelection from initialize
There was a problem hiding this comment.
So can we switch it back to 40? This should speed up the tests.
|
Two comments that still need to be addressed but we can do it in a followup PR:
|
|
I tested it on my local environment:
|
pdyraga
approved these changes
Mar 12, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:#31
Add verification to make sure that the resulting
groupSignaturewas produced by the specifiedgroupPubKeyfor the correspondingpreviousEntry