Skip to content

Commit

Permalink
Change names of secrets
Browse files Browse the repository at this point in the history
Name of the secret storing private key for the account used for
migration of contracts on Ethereum has been changed, so that we would
have similar naming to that for Celo chain account.
Also names of the ETH_HOSTNAME, ETH_NETWORK_ID and TRUFFLE_NETWORK
secrets have been enhanced with `KEEP_TEST` / `KEEP_TEST_ETH` prefix.
  • Loading branch information
michalinacienciala committed Mar 11, 2021
1 parent c5b995b commit f24cd6e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/contracts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ jobs:

- name: Migrate contracts
env:
TRUFFLE_NETWORK: ${{ secrets.TRUFFLE_NETWORK }}
ETH_HOSTNAME: ${{ secrets.ETH_HOSTNAME }}
CONTRACT_OWNER_ETH_ACCOUNT_PRIVATE_KEY: ${{ secrets.CONTRACT_OWNER_ETH_ACCOUNT_PRIVATE_KEY }}
TRUFFLE_NETWORK: ${{ secrets.KEEP_TEST_ETH_TRUFFLE_NETWORK }}
ETH_HOSTNAME: ${{ secrets.KEEP_TEST_ETH_HOSTNAME }}
CONTRACT_OWNER_ETH_ACCOUNT_PRIVATE_KEY: ${{ secrets.KEEP_TEST_ETH_CONTRACT_OWNER_PRIVATE_KEY }}
run: npx truffle migrate --reset --network $TRUFFLE_NETWORK # writes artifacts to /home/runner/work/keep-core/keep-core/solidity/build/contracts

- name: Push contracts to Tenderly
Expand All @@ -148,7 +148,7 @@ jobs:
working-directory: ./solidity
tenderly-token: ${{ secrets.TENDERLY_TOKEN }}
tenderly-project: thesis/keep-test
eth-network-id: ${{ secrets.ETH_NETWORK_ID }} # currently ='3' (ropsten)
eth-network-id: ${{ secrets.KEEP_TEST_ETH_NETWORK_ID }} # currently ='3' (ropsten)
github-project-name: keep-core
# version-tag: # TODO: resolve npm package version

Expand Down

0 comments on commit f24cd6e

Please sign in to comment.