Add support for Symfony 4 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbarn any chance to merge this and release it ? Symfony 4 was released 8 months ago (4.0 already reached its end of maintenance, and is in security-only mode now) |
|
hey @stof! I no longer am managing this SDK because I no longer work at Keen IO. You might be able to get some help through Keen's support. |
|
@tbarn do you know who is the maintainer now ? |
|
@stof Going through support is going to be your best bet. |
k-k
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
@stof Looks like I can take care of this. Would definitely recommend asking to be added as a maintainer of this repo.
I haven't been actively working with symfony or keen in the past few years and this is pretty low on my radar.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the compatibility work was actually already done by #17. This PR is just about making the composer.json advocate the compatibility and updating the CI.