Merge pull request #12 from stof/better_version

Make the configuration of the version more user-friendly
keenlabs · Apr 12, 2017 · 413d5ea · 413d5ea
2 parents 1f2dcbb + ac48fa1
commit 413d5ea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -14,6 +14,11 @@ public function getConfigTreeBuilder()
         $rootNode
             ->children()
                 ->scalarNode('version')
+                    ->beforeNormalization()
+                        // force the version to be a string, even if the Yaml config files parsed it as float
+                        ->ifTrue(function ($v) { return !is_string($v) && is_numeric($v); })
+                        ->then(function ($v) { return number_format($v, 1); })
+                    ->end()
                     ->defaultValue('3.0')
                     ->info('The Keen IO API Version')
                     ->example('3.0')

diff --git a/tests/DependencyInjection/KeenIOExtensionTest.php b/tests/DependencyInjection/KeenIOExtensionTest.php
@@ -37,5 +37,6 @@ public function testConfiguration()
         $this->container->compile();
 
         $this->assertTrue($this->container->has('keen_io'));
+        $this->assertInstanceOf('KeenIO\Client\KeenIOClient', $this->container->get('keen_io'));
     }
 }