Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for hover and navigation #114

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Bug fix for hover and navigation #114

merged 5 commits into from
Sep 18, 2024

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Sep 17, 2024

Context

Currently the cursor is not parsing the correct word when hover over or select namespaced parameters/catalog. For example
params:a.b.c should be parsed as a to retrieve the top-level key.

A better approach of this is a back up search:

  1. Find a.b.c
  2. If not, find a instead

This is a bit tricky because how Kedro users use this inconsisently. For example, in pipeline.py it is always a one-line string:
params:a.b.c, namespace.dataset

In YAML, catalog are defined as oneline:

namespace.dataset:
  key: value

while in parameter file, it is defined as nested key:

top:
  med:
    key: value

So we need to handle this in a 2-steps process in general:

  1. Determine if it's a parameters
  2. Use the corresponding logic to parse out the "target" word

@noklam noklam mentioned this pull request Sep 17, 2024
21 tasks
@noklam noklam requested a review from jitu5 September 18, 2024 13:18
@noklam noklam merged commit 844d135 into main Sep 18, 2024
2 checks passed
@noklam noklam deleted the noklam/fix-navigation-bug branch September 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants