-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to use Kedro after uninstalling Rich. #3838
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
3f39cd3
attempt to configure fallback logger
lrcouto 80f0ff2
Set up fallback for logging on the logging function itself
lrcouto 8c07db1
Lint
lrcouto 6c66689
Lint
lrcouto d883b5d
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto e35cdaa
Merge branch 'main' into remove-rich-as-mandatory-dependence
SajidAlamQB bfbb1f1
Update kedro/logging.py
lrcouto 2038792
Changes to rich variable on logging
lrcouto 5b85711
Lint
lrcouto b75327d
attempt to configure fallback logger
lrcouto de86e8d
Set up fallback for logging on the logging function itself
lrcouto 658d0c1
Lint
lrcouto 609a0c2
Lint
lrcouto 99bd891
Update kedro/logging.py
lrcouto a15bdcd
Changes to rich variable on logging
lrcouto e80d514
Lint
lrcouto f802384
adapt default logging
lrcouto b5aed65
Merge
lrcouto 5061229
Update kedro/logging.py
lrcouto 7c731f3
Create separate logging config file for rich
lrcouto c63c068
Merge branch 'remove-rich-as-mandatory-dependence' of github.com:kedr…
lrcouto a29220c
Hello linter my old friend
lrcouto f43c72c
Alternative for rich in kedro ipython
lrcouto 8389023
Remove unnecessary try/except block
lrcouto 1ea51e8
Update pyproject.toml
lrcouto 6b98284
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 3663bdf
Resolve merge conflict
lrcouto 115d339
Merge branch 'remove-rich-as-mandatory-dependence' of github.com:kedr…
lrcouto 16e05b8
Lint
lrcouto 269ec98
Fix config file paths
lrcouto 5f3640b
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 235a5bf
Update kedro/ipython/__init__.py
lrcouto c1f6cbf
Update kedro/ipython/__init__.py
lrcouto 210b0ed
Prevent kedro ipython from reimporting rich multiple times
lrcouto 98f8e4d
Logging config
lrcouto 191bba7
Change test config
lrcouto b44fb5e
Remove ' yEs ' tests
lrcouto c4c8aa7
Tests to cover ipython changes
lrcouto d76124f
Add test for import
lrcouto 9dbaf94
Ignore test coverage on import try/except
lrcouto 0c63233
Lint
lrcouto f3c65fa
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 1be4b05
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 4775fe4
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 671917d
Unpin cookiecutter version
lrcouto a8fea7a
Merge branch 'remove-rich-as-mandatory-dependence' of github.com:kedr…
lrcouto eb3b151
Add changes to documentation
lrcouto 0f0214f
Update RELEASE.md
lrcouto 192d349
Change RICH variable name to RICH_INTALLED
lrcouto 28534ad
Merge branch 'remove-rich-as-mandatory-dependence' of github.com:kedr…
lrcouto 02d8919
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 2074054
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 8c15acb
Add info about uninstalling rich on logging doc page
lrcouto 6cf7d4d
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 61f44ce
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 6a41b4d
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto 4f57399
Merge branch 'main' into remove-rich-as-mandatory-dependence
lrcouto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
include README.md | ||
include LICENSE.md | ||
include kedro/framework/project/default_logging.yml | ||
include kedro/framework/project/rich_logging.yml | ||
include kedro/ipython/*.png | ||
include kedro/ipython/*.svg | ||
recursive-include kedro/templates * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
version: 1 | ||
|
||
disable_existing_loggers: False | ||
|
||
handlers: | ||
rich: | ||
class: kedro.logging.RichHandler | ||
rich_tracebacks: True | ||
# Advance options for customisation. | ||
# See https://docs.kedro.org/en/stable/logging/logging.html#project-side-logging-configuration | ||
# tracebacks_show_locals: False | ||
|
||
loggers: | ||
kedro: | ||
level: INFO | ||
|
||
root: | ||
handlers: [rich] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section will fit better in the logging docs: https://docs.kedro.org/en/stable/logging/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about putting it in the logging page, as it already mentions
rich
a lot, but since it affects features other than logging I thought it'd fit better as more general configuration information. What do you think about adding it to both pages?