Remove the loading of unused CSS files in the docs #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynandebold
requested review from
yetudada,
astrojuanlu and
merelcht
as code owners
astrojuanlu
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
👍🏽 for now to remove the console errors, but at some point I'll try to get these to a kedro-sphinx-theme of sorts back in version control #3586
Thanks @tynandebold !
|
I cherry picked this in #3675 |
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
…ttings (#3677) * Update pipeline create and delete commands to work with base env in the settings Signed-off-by: Ankita Katiyar <[email protected]> * Return default base value Signed-off-by: Ankita Katiyar <[email protected]> * Ignore unused ignores mypy Signed-off-by: Ankita Katiyar <[email protected]> --------- Signed-off-by: Ankita Katiyar <[email protected]> Signed-off-by: Merel Theisen <[email protected]>
* provide error message outside of kedro project with rich style Signed-off-by: Nok Lam Chan <[email protected]> * change to add custom click message on error instead of overriding get_commands Signed-off-by: Nok Lam Chan <[email protected]> * add test Signed-off-by: Nok Lam Chan <[email protected]> * clean up Signed-off-by: Nok Lam Chan <[email protected]> * catch the error message from click Signed-off-by: Nok Lam Chan <[email protected]> * fix unitests Signed-off-by: Nok Lam Chan <[email protected]> * Update error message Signed-off-by: Nok Lam Chan <[email protected]> * move color constant to the upper module Signed-off-by: Nok Lam Chan <[email protected]> * fix imports Signed-off-by: Nok Lam Chan <[email protected]> * release note Signed-off-by: Nok <[email protected]> --------- Signed-off-by: Nok Lam Chan <[email protected]> Signed-off-by: Nok <[email protected]> Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
merelcht
force-pushed
the
docs/remove-loading-unused-css
branch
from
1281b77
to
ea2ac55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I saw some console errors and noticed some CSS was being loaded using the old pattern.
Development notes
I've removed those lines so these errors should disappear.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile