Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft for #3474
Common strategies https://www.stackhawk.com/blog/spring-path-traversal-guide-examples-and-prevention/:
If we take 1., we should read logging automatically from
conf_source
because this is the most natural location logging.yml sits.Base on what I have read, it seems that injecting full path with environment variable is a bad idea. If we do 1. we need to make sure
settings
is read before_ProjectLogging
(it's reverse now, we should check if this causes any problem).Development notes
https://docs.snyk.io/snyk-cli/getting-started-with-the-snyk-cli
Run
snyk code test
to test it on local.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file