Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sphinx-rtd-theme from 1.2.0 to 2.0.0 #3511

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 15, 2024

Bumps sphinx-rtd-theme from 1.2.0 to 2.0.0.

Changelog

Sourced from sphinx-rtd-theme's changelog.

2.0.0

Added

  • Support for Sphinx versions 6.x and 7.x
  • Support for docutils <=0.20

Deprecations

  • The HTML4 writer is now officially deprecated. An error will be thrown if your project configuration still uses the HTML4 writer.
  • Support for Sphinx versions < 5.0 was removed.
  • In addition, our supported dependencies will match the dependencies from our lowest supported Sphinx release, version 5.0: Python >= 3.6 and docutils > 0.14 and < 0.19

.. _release-1.3.0:

1.3.0

Added

  • Relaxed requirements to include Sphinx release 7.0

.. _release-1.2.2:

1.2.2

Fixes

  • Require sphinxcontrib-jquery>=4,<5 (#1446)

Added

  • Styling for :menuselection: (#1426)

.. _release-1.2.1:

1.2.1

Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) from 1.2.0 to 2.0.0.
- [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst)
- [Commits](readthedocs/sphinx_rtd_theme@1.2.0...2.0.0)

---
updated-dependencies:
- dependency-name: sphinx-rtd-theme
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from merelcht as a code owner January 15, 2024 19:43
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 15, 2024
@stichbury
Copy link
Contributor

Built docs are here and all look OK to me https://kedro--3511.org.readthedocs.build/en/3511/index.html

It occurs to me though, we made some sphinx changes last week as well, didn't we? Now there are other docs subprojects, we will need to to mirror updates to dependencies whenever we change them, or get dependabot working on those subprojects too. How's best to manage for consistency going forward?

@astrojuanlu
Copy link
Member

How's best to manage for consistency going forward?

Creating our own theme as I suggested in #3016 😄

Which by the way would make it easier to tweak CSS again cc @rashidakanchwala

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any differences in output 👍🏽

Build was done with docutils==0.20.1, sphinx-rtd-theme==2.0.0 and Sphinx==7.2.6. We're living on the bleeding edge!

@astrojuanlu astrojuanlu enabled auto-merge (squash) January 16, 2024 11:52
@stichbury
Copy link
Contributor

@astrojuanlu I didn't mean the theme, but the fact that dependabot is bumping Kedro docs dependencies but not the same for Viz or datasets. How'd we handle that?

@astrojuanlu
Copy link
Member

I didn't mean the theme, but the fact that dependabot is bumping Kedro docs dependencies but not the same for Viz or datasets. How'd we handle that?

If our theme depends on the Sphinx extensions we want, we can pin them on the theme and then dependabot would only need to care about 1 repo. They would be transitive depenendencies in kedro, kedro-datasets etc but they wouldn't be explicitly listed, so dependabot would not do anything there.

@astrojuanlu astrojuanlu merged commit 65e9e26 into main Jan 16, 2024
30 checks passed
@astrojuanlu astrojuanlu deleted the dependabot/pip/sphinx-rtd-theme-2.0.0 branch January 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants