-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sphinx-rtd-theme from 1.2.0 to 2.0.0 #3511
Conversation
Bumps [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) from 1.2.0 to 2.0.0. - [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst) - [Commits](readthedocs/sphinx_rtd_theme@1.2.0...2.0.0) --- updated-dependencies: - dependency-name: sphinx-rtd-theme dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Built docs are here and all look OK to me https://kedro--3511.org.readthedocs.build/en/3511/index.html It occurs to me though, we made some sphinx changes last week as well, didn't we? Now there are other docs subprojects, we will need to to mirror updates to dependencies whenever we change them, or get dependabot working on those subprojects too. How's best to manage for consistency going forward? |
Creating our own theme as I suggested in #3016 😄 Which by the way would make it easier to tweak CSS again cc @rashidakanchwala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any differences in output 👍🏽
Build was done with docutils==0.20.1
, sphinx-rtd-theme==2.0.0
and Sphinx==7.2.6
. We're living on the bleeding edge!
@astrojuanlu I didn't mean the theme, but the fact that dependabot is bumping Kedro docs dependencies but not the same for Viz or datasets. How'd we handle that? |
If our theme depends on the Sphinx extensions we want, we can pin them on the theme and then dependabot would only need to care about 1 repo. They would be transitive depenendencies in kedro, kedro-datasets etc but they wouldn't be explicitly listed, so dependabot would not do anything there. |
Bumps sphinx-rtd-theme from 1.2.0 to 2.0.0.
Changelog
Sourced from sphinx-rtd-theme's changelog.
... (truncated)
Commits
7c9b1b5
Release 2.0 final (#1544)c104410
Bump for next potential release, 2.0.0rc5 (#1539)53ca116
Release 2.0.0rc4 (#1538)4498e97
Fix AttributeError when one ofcss_files
is a string (#1537)84aea9b
Increment for next potential release (#1536)febde39
Release 2.0.0rc3 (#1535)32310a8
Fix #1522: fix'str' object has no attribute 'attributes'
(#1528)8ce23ce
Version bump for 2.0rc3 development (#1521)46f5307
Release 2.0rc2 (#1520)5838e6a
Add support fordocutils==0.20.x
(#1517)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)