Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pip-tools as dependency #3329

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Remove pip-tools as dependency #3329

merged 9 commits into from
Nov 22, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Nov 22, 2023 •
edited
Loading

Description

Part of #2350

Development notes

Removed pip-tools as dependency and updated the test starter to use pyproject.toml instead of setup.py.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@merelcht
Update release notes
205f3cc 
Signed-off-by: Merel Theisen <[email protected]>
@merelcht merelcht changed the title Try remove setuptools Remove pip-tools as dependency Nov 22, 2023
@merelcht merelcht marked this pull request as ready for review November 22, 2023 12:23
@merelcht merelcht self-assigned this Nov 22, 2023
ankatiyar
ankatiyar approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merelcht 💯

SajidAlamQB
SajidAlamQB approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @merelcht! 👍

@merelcht merelcht merged commit 8b4907d into develop Nov 22, 2023
36 checks passed
@merelcht merelcht deleted the merel-remove-setuptools branch November 22, 2023 13:18
stichbury pushed a commit that referenced this pull request Nov 28, 2023
@merelcht @stichbury
Remove pip-tools as dependency (#3329)
f8117fa 
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
@AhdraMeraliQB AhdraMeraliQB mentioned this pull request Jan 2, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankatiyar ankatiyar ankatiyar approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merelcht @SajidAlamQB @ankatiyar