Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not initialize Mermaid JS #2452

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Do not initialize Mermaid JS #2452

merged 2 commits into from
Mar 22, 2023

Conversation

astrojuanlu
Copy link
Member

Fix gh-2451.

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@astrojuanlu
Do not initialize Mermaid JS
c5c7f50 
Fix gh-2451.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
@astrojuanlu
Copy link
Member Author

astrojuanlu commented Mar 22, 2023 •
edited
Loading

Before: https://docs.kedro.org/en/latest/deployment/deployment_guide.html (view source)

With this PR: https://kedro--2452.org.readthedocs.build/en/2452/deployment/deployment_guide.html

stichbury
stichbury approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you 🙏

@astrojuanlu astrojuanlu mentioned this pull request Mar 22, 2023
Closed
@astrojuanlu
Allow warnings in documentation
add76ff 
"Temporary" (hopefully) workaround for gh-2453.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
@astrojuanlu astrojuanlu requested a review from idanov as a code owner March 22, 2023 11:30
@astrojuanlu
Copy link
Member Author

Welp, I've done it: I've disabled Sphinx strict mode on Read the Docs because of gh-2453.

I commit to finding a proper solution as part of the work we're doing in #2072, but for now and to avoid blocking more PRs, I think it's reasonable to turn the setting off temporarily. @stichbury

@astrojuanlu astrojuanlu requested a review from merelcht March 22, 2023 11:43
@astrojuanlu astrojuanlu mentioned this pull request Mar 22, 2023
Closed
@astrojuanlu astrojuanlu merged commit c42b9cd into main Mar 22, 2023
@astrojuanlu astrojuanlu deleted the docs/fix-mermaid branch March 22, 2023 12:27
jmholzer pushed a commit that referenced this pull request Mar 29, 2023
@astrojuanlu @jmholzer
Do not initialize Mermaid JS (#2452)
aeada8e 
* Do not initialize Mermaid JS

Fix gh-2451.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Allow warnings in documentation

"Temporary" (hopefully) workaround for gh-2453.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stichbury stichbury stichbury approved these changes

@merelcht merelcht merelcht approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@idanov idanov Awaiting requested review from idanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mermaid JS included too many times
3 participants
@astrojuanlu @stichbury @merelcht