-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise visualisation documentation for Plotly charts, Matplotlib #2061
Conversation
Mostly removing text and simplifying FTW Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Ankita Katiyar <[email protected]>
….com/kedro-org/kedro into kedro-1874-spaceflights-improvements
….com/kedro-org/kedro into kedro-1874-spaceflights-improvements
….com/kedro-org/kedro into kedro-1874-spaceflights-improvements
Co-authored-by: Nok Lam Chan <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these improvements!
I just left a comment about the repeated node name for the compare_passenger_capacity
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @stichbury ! And good thinking on adding a note about this working up to Kedro 0.18.3
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's great to me. thanks @stichbury
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The revisions to this documentation are sorely needed! Thanks for leading this @stichbury! I've left some comments on structure, user-friendliness and minor formatting.
Co-authored-by: Yetunde Dada <[email protected]>
Co-authored-by: Yetunde Dada <[email protected]>
Update the documentation about plotly charts and general intro to kedro viz. More to come on experiment tracking.
This PR is now ready for review.
Description
Resolves #1949
I've made some improvements to the docs for Kedro-Viz in the "Visualisation with Kedro-Viz" section:
You can see the files changed here: https://stichbury.github.io/
It's probably easier to review the built HTML instead of the diffs but any feedback would be appreciated. Since we released 18.4 i've tried to rebuild the example and now I cannot get the chart to show in viz. I've also updated my Mac OS to the latest version and I've no idea which of those changes (or something else) has broken the charts.
Tested on Chrome & Safari.
Checklist
RELEASE.md
file