Deprecate kedro test and kedro lint

[noklam]

Signed-off-by: Nok Chan [email protected]

Description

Close #1872

Development notes

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the RELEASE.md file
• Added tests to cover my changes

[AhdraMeraliQB]

Thanks for picking this up!

[deepyaman]

Do we need to point out that users should call linters directly? Do we need to specify which ones?

[noklam]

I am less sure about this one, maybe it will become more clear when #1620 is done. I am fine we either wait until #1620 is done or just merge this one and add some links when the docs PRs are done.

[deepyaman]

Just to be clear, this means we are not wrapping pytest in a Kedro command, but we're still supporting pytest, right? Since, if we were just going to say "testing is up to you now," we shouldn't call out pytest in the message.

I think it's fine as-is, if I've understood correctly.

[noklam]

I think we will still have some tests in starters? This isn't too important though, as this deprecating message is for 0.18.x, we will still support pytest until 0.19.0, so this message is just asking people to use pytest instead of kedro test.
#1879 is a more detailed docs for how to use pytest.

[jmholzer]

Determining whether or not tests will still be in starters is part of an open issue (#1849).

[jmholzer]

I personally wouldn't mention pytest as an alternative in this message, I think this also would keep things consistent with the linting message.

[noklam]

I am gonna leave it as is. I don't think it matters too much and I am fine with either option.

I checked in 0.17.x we did similar thing for kedro install

kedro/kedro/framework/cli/project.py

Lines 175 to 180 in 80c0d3a

	deprecation_message = (
	"DeprecationWarning: Command `kedro install` will be deprecated in Kedro 0.18.0. "
	"In the future use `pip install -r src/requirements.txt` instead. "
	"If you were running `kedro install` with the `--build-reqs` flag, "
	"we recommend running `kedro build-reqs` followed by `pip install -r src/requirements.txt`"
	)

[deepyaman]

Suggested change

	* `kedro test`, `kedro lint` will be deprecated.
	* `kedro test` and `kedro lint` will be deprecated.

[jmholzer]

Happy to approve this PR as it is, though I left a comment on the deprecation of kedro test.