Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular Pipeline Documentation updates #1578

Merged
merged 3 commits into from
May 30, 2022
Merged

Modular Pipeline Documentation updates #1578

merged 3 commits into from
May 30, 2022

Conversation

roger-yu-ds
Copy link
Contributor

@roger-yu-ds roger-yu-ds commented May 29, 2022 •
edited by gitpod-io bot
Loading

Description

Fixes to the documentation

Development notes

e9655f7

Tested a similar set up to the documentation and it didn't work.
Tested a similar set up to the proposed change and it worked.

Checklist

  • [x ] Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@roger-yu-ds
Update modular_pipelines.md
e9655f7 
The upstream pipeline is responsible for mapping its outputs, in this case "grilled_veg" is mapped to "food" so that the downstream pipeline can use the input as "food".
@roger-yu-ds
Update documentation_contributor_guidelines.md
c7e89ff 
Grammatical fix.
@noklam noklam changed the title Documentation updates Modular Pipeline Documentation updates May 30, 2022
@noklam noklam self-assigned this May 30, 2022
@noklam noklam added the Component: Documentation 📄 Issue/PR for markdown and API documentation label May 30, 2022
@noklam noklam self-requested a review May 30, 2022 16:05
noklam
noklam approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the PR, nicely done!

SajidAlamQB
SajidAlamQB approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🌟

@noklam noklam merged commit b2e59fa into kedro-org:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@noklam noklam noklam approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@AhdraMeraliQB AhdraMeraliQB Awaiting requested review from AhdraMeraliQB

Assignees

@noklam noklam

Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roger-yu-ds @noklam @SajidAlamQB